Various performance improvements to the store

[absidue]

Various performance improvements to the store

Pull Request Type

• Performance improvement

Description

As my store typings pull request seems to not work for some people (some IDEs struggle with the complicated type gynastics that were required to get that pull request to work), I've decided to extract the performance improvements from that pull request into their own one and add a few other minor improvements to the mix. That way we get those improvements regardless of whether we ever merge the other pull request.

Here is the list of improvements:

• Pass the locale string to the getRegionData action directly instead of wrapping it in an object. Using an object is only necessary when an action takes multiple parameters.
• Access the state directly instead of going through the getters, in some of the places that we weren't already doing that.
• The list of settings that have side-effects never changes at runtime, so we have no reason to store it in the state and access it through a getter. We can just store it in a normal variable and access it directly to avoid the extra overhead.

Testing

Check that changing the locale still fetches the appropriate region translations.

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: 0.21.3