Move the channel details into their own component #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Jul 25, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 26, 2024
ChunkyProgrammer
approved these changes
Jul 29, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 1, 2024
* update/youtubejs: ^ Update youtubei.js Translated using Weblate (Russian) Translated using Weblate (Croatian) Fix distraction settings and subscribe button CSS not being scoped (FreeTubeApp#5486) Move the channel details into their own component (FreeTubeApp#5455) Translated using Weblate (Icelandic) Bump postcss from 8.4.39 to 8.4.40 in the stylelint group (FreeTubeApp#5492) Translated using Weblate (Icelandic) Bump the babel group with 2 updates (FreeTubeApp#5490) Bump marked from 13.0.2 to 13.0.3 (FreeTubeApp#5496) Bump lefthook from 1.7.5 to 1.7.11 (FreeTubeApp#5497) Bump the eslint group with 4 updates (FreeTubeApp#5491) Bump electron from 31.2.1 to 31.3.0 (FreeTubeApp#5493) Bump swiper from 11.1.5 to 11.1.8 (FreeTubeApp#5494) Translated using Weblate (Azerbaijani) Translated using Weblate (Azerbaijani) Translated using Weblate (Azerbaijani) Translated using Weblate (Azerbaijani)
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 1, 2024
* custom-builds/current: ^ Update youtubei.js Translated using Weblate (Russian) Translated using Weblate (Croatian) Fix distraction settings and subscribe button CSS not being scoped (FreeTubeApp#5486) Move the channel details into their own component (FreeTubeApp#5455) Translated using Weblate (Icelandic) Bump postcss from 8.4.39 to 8.4.40 in the stylelint group (FreeTubeApp#5492) Translated using Weblate (Icelandic) Bump the babel group with 2 updates (FreeTubeApp#5490) Bump marked from 13.0.2 to 13.0.3 (FreeTubeApp#5496) Bump lefthook from 1.7.5 to 1.7.11 (FreeTubeApp#5497) Bump the eslint group with 4 updates (FreeTubeApp#5491) Bump electron from 31.2.1 to 31.3.0 (FreeTubeApp#5493) Bump swiper from 11.1.5 to 11.1.8 (FreeTubeApp#5494) Translated using Weblate (Azerbaijani) Translated using Weblate (Azerbaijani) Translated using Weblate (Azerbaijani) Translated using Weblate (Azerbaijani) # Conflicts: # package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the channel details into their own component
Pull Request Type
Related issue
https://github.com/orgs/FreeTubeApp/projects/4?pane=issue&itemId=68600889
Description
This pull request moves the channel details section (header and tabs) into their own component, continuing the efforts to split the channel page up into multiple components.
As we'll hopefully be moving the Vue 3 soon, I decided to the use the
<script setup>composition API style for this new component. That means inside that component we can already benefit from better auto-complete and once we upgrade to Vue 3 we'll also get better performance and bundle size improvements.Testing
Hide Channel Subscribersdistraction free setting hides the subscriber count.Hide Unsubscribe Buttonparental control setting hides the subscribe/unsubscribe button.Desktop