-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blocking error when navigating away from an age-restricted video #5343
Merged
FreeTubeBot
merged 3 commits into
FreeTubeApp:development
from
absidue:age-restricted-error
Jul 4, 2024
Merged
Fix blocking error when navigating away from an age-restricted video #5343
FreeTubeBot
merged 3 commits into
FreeTubeApp:development
from
absidue:age-restricted-error
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
June 26, 2024 19:29
github-actions
bot
added
the
PR: waiting for review
For PRs that are complete, tested, and ready for review
label
Jun 26, 2024
Fixed the watch history and playlist code too now. |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jun 30, 2024
kommunarr
reviewed
Jun 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (pre-existing, non-blocking): With autoplay enabled on an age-restricted video, the Next Video countdown appears, but don't seem to actually do anything upon completion.
Co-authored-by: Jason <[email protected]>
ChunkyProgrammer
approved these changes
Jul 3, 2024
ChunkyProgrammer
requested review from
kommunarr and
efb4f5ff-1298-471a-8973-3d47447115dc
July 3, 2024 03:00
kommunarr
approved these changes
Jul 3, 2024
PikachuEXE
approved these changes
Jul 4, 2024
github-actions
bot
removed
the
PR: waiting for review
For PRs that are complete, tested, and ready for review
label
Jul 4, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix blocking error when navigating away from an age-restricted video
Pull Request Type
Related issue
closes #5319
Description
handleRouteChange
assumes there is always a player available, which causes problems when you try to navigate away from an age-restricted video withShow family friendly content only
enabled, as we don't create a player in that situation. That caused an error to get thrown, which in turn meant that thenext
function was not getting called in thebeforeRouteLeave
hook, making it impossible to navigate away from the watch page.Testing
Show family friendly content only
in the parental controls settingsDesktop