Move ft-list-channel specific css to ft-list-channel.scss #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 5, 2024
ChunkyProgrammer
approved these changes
Apr 5, 2024
PikachuEXE
approved these changes
Apr 6, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ft-list-channel specific css to ft-list-channel.scss
Pull Request Type
Description
This pull request move CSS that is only used by the
ft-list-channelcomponent into theft-list-channel.scssfile from the_ft-list-item.scssfile. Not only does this make it easier to find when someone looks for it in the future, it also reduces the CSS output (renderer.[hash].css) by2777bytes.Why does the output shrink just by copying it from one file to another?
SCSS'
@usedirective copies the referenced CSS into the file that has the@usedirective, that means it is copied into 5 files/componentsft-list-video,ft-list-channel,ft-list-playlist,ft-list-hashtagandft-community-post. That copying is good, because it means we have consistent styling across our list components and Vue can correctly scope the CSS to the component. In this case however, it's CSS that is only used in one of those five components, so it doesn't make sense to copy it into the other four.Testing
Search for a channel (e.g. MrBeast) and check that it appears correct in the search results.
Desktop