Fix app starting in fullscreen if a fullscreen video is closed #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
|
After upcoming stable release, i will ask if people still experiencing this in #3220 |
|
In both dev mode and with your provided build, im still getting fullscreened after quitting the video player in fullscreen using idk if it matters but, dev mode is in Ubuntu and build installed on win10 |
|
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: WIP
and removed
PR: waiting for review
|
If the current fix does not work, I'm really not quite sure what to do. |
|
Maybe co creator @absidue has an idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix app starting in fullscreen if a fullscreen video is closed
Pull Request Type
Related issue
closes #4534
Description
Co-created with @absidue. Fixes issue of the app starting in fullscreen if a video was closed in fullscreen.
Screenshots
Testing
Desktop
Additional context
IIRC, fullscreen works differently in dev mode versus an actual build. Here are the builds, if that helps.