Add back 3 Stylelint configs #4350
Conversation
Notably, we choose to not use the 'a11y/no-outline-none' rule. The reason for this being that our focus ring suffices for almost every use case (https://www.w3.org/WAI/WCAG22/Understanding/focus-appearance-minimum), and using the same hover and focus styling can be considered bad design in many cases. YT goes the direction of foregoing the focus ring for many of its components and choosing a barely darker color than its :hover for :focus styling, which is controversial. Accessibility-wise, at the very least, using the same hover and focus styling can be confusing, especially for sighted users who use keyboard navigation.
This is not recognized as a fix by the rule due to its limited detection logic, so this rule is not being imported directly.
github-actions
bot
added
the
PR: waiting for review
| @@ -369,6 +369,7 @@ | |||
| <ft-element-list | |||
| v-if="!hideChannelCommunity && currentTab === 'community'" | |||
| id="communityPanel" | |||
There was a problem hiding this comment.
Still referenced by aria-controls somewhere
There was a problem hiding this comment.
We still have the ID. Just added it as a class as well
There was a problem hiding this comment.
Yup I know. It's for other reviewers (coz diff won't show aria-controls
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer,
MarmadileManteater and
PikachuEXE
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
… feat/add-back-stylelint-1
…at/add-back-stylelint-1
…ecificity Properly implementing the no-descending-specificity rule in this file seems to utterly destroy the styling. This would be its own entire initiative to unravel.
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Requesting re-review. CC: @absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @MarmadileManteater |
github-actions
bot
added
PR: waiting for review
|
After combing through the files and doing more testing, |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…at/add-back-stylelint-1
kommunarr
dismissed stale reviews from ChunkyProgrammer and PikachuEXE
via
88d6728
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
…at/add-back-stylelint-1
kommunarr
dismissed stale reviews from PikachuEXE and ChunkyProgrammer
via
3deda96
|
This is currently passing for all files. Please get this one in next if possible! |
github-actions
bot
removed
the
PR: waiting for review
(Will wait after we're done adding things for the release)
Add back 3 Stylelint configs
Pull Request Type
Related issue
See chore
Description
Changes from initial (intended) config:
selector-no-qualifying-typenow ignores attribute selectorsa11y/font-size-is-readableis removed (see discussion)[media-prefers-reduced-motion](https://github.com/double-great/stylelint-a11y/blob/main/src/rules/media-prefers-reduced-motion/README.md)is now satisfied (but not added as a rule due to the limited capabilities of the Stylelint config)Testing
This is a tough one to have clear testing requirements for. Many files were "changed," but pretty insubstantially so, and none should be changed functionally (excluding our new support for users with
prefers-reduced-motion).prefers-reduced-motionand validate that our transitions and animations are no longer present (can be simulated by removing the media query surrounding it on line 1062 ofthemes.css. Time: <5 minDesktop
Additional info
The only remaining Stylelint config of the original list to implement after this PR is stylelint-high-performance-animation. The issues to be fixed there are seemingly non-trivial and preferably placed in a separate effort.