Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recommended video section to use hide videos from channel preference #3749

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Update recommended video section to use hide videos from channel preference #3749

merged 4 commits into from
Jul 13, 2023

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Jul 10, 2023 •
edited
Loading

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Addresses #3744, for a feature introduced in #2849

Description

Now recommended videos section & most popular view also hide videos from channels in "Hide Videos From Channels"

Screenshots

LTT hidden in https://youtu.be/Rt78MqJDozY
image

Testing

A

  • Add random channel to preference (ensure there is a video with recommended video(s) with tested channel)
  • Visit video
  • Ensure video(s) absent in recommended section

B

  • Add random channel to preference (ensure there is a video in most popular view with tested channel)
  • Browse most popular view
  • Ensure video(s) absent

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 10, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) July 10, 2023 06:30
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for addressing this. Before approve just a thought, should we maybe edit this description so the user knows that its also hidden in the up next section?

Capture

@PikachuEXE
Copy link
Collaborator Author

Yes, but not sure how detailed should the text be. Any idea?

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

[...] appearing in search, trending and recommended.

@PikachuEXE
Copy link
Collaborator Author

Updated but I use or from original value

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

With or it sound to me that the user can choose the places to hide channels. That's why i replaced it with and

PikachuEXE
PikachuEXE commented Jul 11, 2023
View reviewed changes
Copy link
Collaborator Author

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too lazy to switch computer

static/locales/en-US.yaml Outdated Show resolved Hide resolved
static/locales/en_GB.yaml Outdated Show resolved Hide resolved
@PikachuEXE
Copy link
Collaborator Author

most popular view updated too, testing updated

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FreeTubeBot FreeTubeBot merged commit 325b36e into FreeTubeApp:development Jul 13, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 13, 2023
@PikachuEXE PikachuEXE deleted the fix/hide-channels-in-recommended-videos branch July 13, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @ChunkyProgrammer @FreeTubeBot