Update some views to opt out of "Hide Videos From Channels" #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 10, 2023
absidue
approved these changes
Jul 12, 2023
ChunkyProgrammer
approved these changes
Jul 13, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Addresses #3744, for a feature introduced in #2849
Description
Update following views to opt out of "Hide Videos From Channels", e.g. ignore channels to hide preference
Only reachable when user wants to view it explicitly, no point viewing the channel with all content hidden
Avoid unexpected false sense of absence when searching
User subscribe for channels explicitly
User add videos into user playlist(s) explicitly
Screenshots
Lazy
Testing
Mentioned views should still show content for channels added to "Hide Videos From Channels"
Other views (search, trending, popular, etc.) should still have stuff from channels in "Hide Videos From Channels" hidden
Desktop
Additional context