Utils: Don't provide ytdl:// protocol links to external players
#3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing these type of links is currently unnecessary and can turn into a hassle when the players are extended by scripts that are not expecting them and don't function as intended.
github-actions
bot
added
the
PR: waiting for review
Svallinn
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
PikachuEXE
approved these changes
Jul 2, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 3, 2023
absidue
approved these changes
Jul 3, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jul 6, 2023
* development: (21 commits) Translated using Weblate (Portuguese) Translated using Weblate (Portuguese (Portugal)) Translated using Weblate (Czech) Translated using Weblate (French) Translated using Weblate (Norwegian Bokmål) Translated using Weblate (Japanese) Translated using Weblate (Spanish) Translated using Weblate (Hebrew) Translated using Weblate (Arabic) Translated using Weblate (Italian) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Ukrainian) Translated using Weblate (Hungarian) Translated using Weblate (Turkish) Add DeArrow support for ft-list-video titles (FreeTubeApp#3688) Utils: Don't provide `ytdl://` protocol links to external players (FreeTubeApp#3720) Bump electron from 22.3.14 to 22.3.15 (FreeTubeApp#3723) Bump webpack from 5.88.0 to 5.88.1 (FreeTubeApp#3722) Bump eslint from 8.43.0 to 8.44.0 (FreeTubeApp#3724) ... # Conflicts: # src/renderer/components/ft-list-video/ft-list-video.js
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jul 6, 2023
* feature/playlist-2023-05: (21 commits) Translated using Weblate (Portuguese) Translated using Weblate (Portuguese (Portugal)) Translated using Weblate (Czech) Translated using Weblate (French) Translated using Weblate (Norwegian Bokmål) Translated using Weblate (Japanese) Translated using Weblate (Spanish) Translated using Weblate (Hebrew) Translated using Weblate (Arabic) Translated using Weblate (Italian) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Ukrainian) Translated using Weblate (Hungarian) Translated using Weblate (Turkish) Add DeArrow support for ft-list-video titles (FreeTubeApp#3688) Utils: Don't provide `ytdl://` protocol links to external players (FreeTubeApp#3720) Bump electron from 22.3.14 to 22.3.15 (FreeTubeApp#3723) Bump webpack from 5.88.0 to 5.88.1 (FreeTubeApp#3722) Bump eslint from 8.43.0 to 8.44.0 (FreeTubeApp#3724) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Providing these type of links is currently unnecessary and can turn into a hassle when the players are extended by scripts that are not expecting them and don't function as intended.
Desktop
development(242c93e)