Only use android formats when the video id in the response is correct #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jul 2, 2023
ChunkyProgrammer
previously approved these changes
Jul 2, 2023
Co-authored-by: ChunkyProgrammer <[email protected]>
absidue
dismissed
efb4f5ff-1298-471a-8973-3d47447115dc’s stale review
via
5b7daaf
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 2, 2023
This was referenced Jul 2, 2023
PikachuEXE
approved these changes
Jul 3, 2023
ChunkyProgrammer
approved these changes
Jul 3, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use android formats when the video id in the response is correct
Pull Request Type
Related issue
Follow up to #3715
Description
Sometimes when YouTube detects a third party client or has applied an IP-ratelimit, they replace the response with a different video id. Here are the issues about it in the NewPipe and Piped repositories:
TeamNewPipe/NewPipe#8713
TeamPiped/Piped#2487
This pull request adds a check to detect that, just in case it happens.
Testing
Doesn't change any behaviour at the moment, so feel free to test but you shouldn't notice anything different at the moment.