Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes to allow us to blend in more #3718

Merged
merged 6 commits into from
Jul 3, 2023

Conversation

absidue
Copy link
Member

@absidue absidue commented Jul 1, 2023

Various changes to allow us to blend in more

Pull Request Type

  • Bugfix

Description

This pull requests makes various changes to allow us to blend in more with YouTube's requests, like removing Electron/<version> and FreeTube/<version> from the user agent, setting the referer and origin headers for requests to the Innertube and the googlevideo domains.
I also decided to switch to letting YouTube generate the session for the watch page Innertube requests as those are the most sensitive ones.

This pull request doesn't fix the throttling issue, #3715 addresses that.

Testing

Check that everything still works/is as broken as it was before.

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) July 1, 2023 13:56
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 1, 2023
@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jul 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@absidue absidue added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 2, 2023
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed a network request's headers
image

Edit: for videoplayback
image

@FreeTubeBot FreeTubeBot merged commit 6163ad7 into FreeTubeApp:development Jul 3, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 3, 2023
@absidue absidue deleted the blend-in branch July 3, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants