Add back sort by oldest #3698
Merged
Add back sort by oldest #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
|
I got this with Invidious version specific? |
|
The version has to be at least version 2023-06-21 |
PikachuEXE
approved these changes
Jun 26, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 27, 2023
ChunkyProgrammer
approved these changes
Jun 27, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back sort by oldest
Pull Request Type
Related issue
closes #3691
Description
This pull request adds back the oldest sort option for the videos and live tabs on channel pages, now that YouTube has finally added them back. YouTube doesn't support sorting by oldest on the shorts tab, presumably because they don't display the published dates there.
Invidious doesn't support sorting the shorts or live tabs, so currently you'll just see the same results as when it is sorted by newest. Once they add support, it should just start working in FreeTube, as we already pass the relevant parameters to the API.
Screenshots
Testing
Local API:
Test the oldest sort option on both the videos and live tabs.
Invidious API:
Test the oldest sort option for the videos tab (Invidious doesn't support sorting the live or shorts tabs).