Cleanup some duplicate channel tab URL handling code

[absidue]

Cleanup some duplicate channel tab URL handling code

Pull Request Type

• Refactor

Related issue

Noticed while working on #3689

Description

As we already removed hidden tabs from the tabInfoValues array, we can check if the tab in the link is in that array, instead of duplicating the same checks to other places in the code.

tabInfoValues:

FreeTube/src/renderer/views/Channel/Channel.js

Lines 203 to 235 in b0eb157

	tabInfoValues: function () {
	const values = [
	'videos',
	'shorts',
	'live',
	'playlists',
	'community',
	'about'
	]
	// remove tabs from the array based on user settings
	if (this.hideChannelShorts) {
	const index = values.indexOf('shorts')
	values.splice(index, 1)
	}
	if (this.hideLiveStreams) {
	const index = values.indexOf('live')
	values.splice(index, 1)
	}
	if (this.hideChannelPlaylists) {
	const index = values.indexOf('playlists')
	values.splice(index, 1)
	}
	if (this.hideChannelCommunity) {
	const index = values.indexOf('community')
	values.splice(index, 1)
	}
	return values
	}

Testing

Try various channel links with tabs in them, to make sure they work correctly when tabs are hidden.

[PikachuEXE]

Maybe also eliminate this duplicate code part?

    let currentTab = this.$route.params.currentTab ?? 'videos'

    if (!this.tabInfoValues.includes(currentTab)) {
      currentTab = this.tabInfoValues[0]
    }

    this.currentTab = currentTab

[efb4f5ff-1298-471a-8973-3d47447115dc]

LGTM