Fix Hide Channel Subscribers setting still displaying subscribers if changed from a secondary window (#3504) #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changed from a secondary window (#3504)
github-actions
bot
added
the
PR: waiting for review
5 tasks
PikachuEXE
requested changes
Jun 22, 2023
auto-merge was automatically disabled
June 22, 2023 18:21
Head branch was pushed to by a user without write access
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
absidue
reviewed
Jun 24, 2023
auto-merge was automatically disabled
June 25, 2023 11:07
Head branch was pushed to by a user without write access
…channel.js Co-authored-by: absidue <[email protected]>
PikachuEXE
approved these changes
Jun 25, 2023
absidue
approved these changes
Jun 25, 2023
ChunkyProgrammer
approved these changes
Jun 25, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Hide Channel Subscribers setting still displaying subscribers if changed from a secondary window (#3504)
Pull Request Type
Related issue
closes #3504
Description
I fixed this issue in 3 components:
Because
hideChannelSubscriptionsis state that can be updated, the places where this was implemented did not seem to take that into account.For example, in the Channel.js the getChannelLocal only gets called when the component is mounted. In that method they are setting the
this.subCountstate tonullifhideChannelSubscriptionsisfalse. Normally this would not be an issue because the component would be remounted if you go back and forth between pages, but because we have two windows open that means thethis.subCountvalue will always stay null.There may be some other "distraction free settings" that have the same issues. Although unless someone uses two windows simultaneously it should be barely an issue.
Screenshots
(Example channel page)
Before:
After:
Testing
I hand tested this issue by switching the
Hide Channel Subscriberson/off.Desktop