Update subscription view to be able to load videos from video cache again

[PikachuEXE]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

There is another caching strategy in #3668

Description

This is a change as base for adding live stream tab for subscription view
The original plan is to only refactor the code first but some existing code/feature seems disabled (intentionally or accidentally I am not sure)

Load videos from video cache

When videos for all subscriptions loaded (main profile), there is some code (though disabled due to bug) to cache all loaded videos and use those when active profile changed

The flow in this PR is like:

• Loading videos from remote would put those profile ID, videos (and other stuff) in a local cache for active profile (now called subscriptionsCacheForActiveProfile)
  • Additionally if the active profile is default profile it would also store the videos (only) into another cache (now subscriptionsCacheForAllSubscriptionsProfile)
  • Else (non default profile), it will clear subscriptionsCacheForAllSubscriptionsProfile
• Switching to another profile would load videos from cache subscriptionsCacheForActiveProfile if profile ID matches
• Else if subscriptionsCacheForAllSubscriptionsProfile has videos cached it would load videos from it with filtering (video channel is in active profile)
• Else load videos automatically if preference set
• Else do nothing

Screenshots

For loading from subscriptionsCacheForAllSubscriptionsProfile

Screen.Recording.2023-06-14.at.14.28.21.mov

Testing

Preparation:

• Create 3+ profiles (other than default)
• 2 with overlapping (or not) channels (A, B), 1 with no channels (C)

Before starting each test please reopen window/app/refresh to ensure local state is reset

A. Auto fetching disabled
A1. Loading from subscriptionsCacheForAllSubscriptionsProfile

• Switch to default profile (if not already)
• Ensure no video loaded
• Load videos from remote (via button, KB shortcut whatever)
• Ensure videos loaded
• Switch to profile A
• Ensure correct videos loaded, no network request made for fetching videos
• Switch to profile B
• Ensure correct videos loaded, no network request made for fetching videos
• Switch to profile C
• Ensure correct (no) videos loaded, no network request made for fetching videos
• Switch to default profile
• Ensure correct (all) videos loaded, no network request made for fetching videos

A2. Auto clearing of subscriptionsCacheForAllSubscriptionsProfile & Loading from subscriptionsCacheForActiveProfile

• Switch to default profile (if not already)
• Load videos from remote
• Ensure videos loaded
• Switch to profile A
• Load videos from remote
• Switch to default profile
• Ensure NO videos loaded
• Switch to profile A
• Ensure correct videos loaded, no network request made for fetching videos
• Switch to profile B
• Ensure NO videos loaded

B. Auto fetching enabled
B1. Loading from subscriptionsCacheForAllSubscriptionsProfile

• Same as A1 except Load videos from remote is done automatically

B2. Auto clearing of subscriptionsCacheForAllSubscriptionsProfile & Loading from subscriptionsCacheForActiveProfile

• Switch to default profile (if not already)
• Ensure videos loaded
• Switch to profile A
• Load videos from remote (manually)
• Switch to profile B
• Ensure correct videos loaded, with network request made for fetching videos
• Switch to default profile
• Ensure correct videos loaded, with network request made for fetching videos

Desktop

• OS:
• OS Version:
• FreeTube version:

Additional context

Refactoring code and typing test cases & testing might be more tiring than actual implementation

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[efb4f5ff-1298-471a-8973-3d47447115dc]

So this can be closed?

[PikachuEXE]

Replaced by merged #3668