Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IV: add support for hashtag pages #3571

Merged

Conversation

ChunkyProgrammer
Copy link
Member

IV: add support for hashtag pages

Pull Request Type

  • Feature Implementation

Related issue

Follow up to #3483
Relies on iv-org/invidious#3692

Description

This PR adds hashtag page support when using the invidious api

Testing

  • use invidious as primary api (no fallback)
  • switch to an invidious instance that has support or the hashtag api in it
  • go to a hashtag page
  • load more videos

Desktop

  • OS: Windows
  • OS Version: 11
  • FreeTube version: 0.18.0

@absidue
Copy link
Member

absidue commented May 22, 2023

I know this is marked as a draft, so this is something that should probably be done last minute. Please remove the string from all of the other language files too, although best to wait until it's ready to merge so it can be removed from as many files as possible, even ones that get translated in the mean time.

@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review May 23, 2023 21:57
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 23, 2023 21:57
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 23, 2023
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with instance https://invidious.nerdvpn.de (version 2023.05.23-e238c08)

@FreeTubeBot FreeTubeBot merged commit 8dbad61 into FreeTubeApp:development May 26, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 26, 2023
@ChunkyProgrammer ChunkyProgrammer deleted the iv-hashtag-support branch May 26, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants