Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using piped api for comments, playlists, search suggestions and trending #3559

Draft
wants to merge 137 commits into
base: development
Choose a base branch
from
Draft

Allow using piped api for comments, playlists, search suggestions and trending #3559

wants to merge 137 commits into from
+1,232 −156

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented May 16, 2023 •
edited
Loading

Allow using piped api for comments, playlists, search suggestions and trending

NOTE: THIS PR SHOULD BE MERGED AFTER THE V0.21 RELEASE.

Pull Request Type

  • Feature Implementation

Related issue

#1527
The commits for #3488 seems to have messed up on github's side (This PR was created with the same branch but has 20 less commits?)

Description

This PR will add support for using the piped api for comments, playlists and trending

Testing

Comments

  • set preferred api backend to piped
  • go to a video
  • load comments
  • load replies
  • load more comments

Playlists

  • set preferred api backend to piped
  • search a playlist
  • go to the playlist page
  • load more
  • click on a video
  • notice that all playlist videos are shown (unlike Invidious)

Trending

  • go to the trending page

  • it loads

  • click on music tab, trending page uses fallback api

  • make invidious the primary api with piped as fallback

  • set invidious api to an invalid url (ex: meow)

  • go to trending page, click on gaming & get an error (piped doesnt support trending tabs)

Desktop

  • OS: Windows
  • OS Version: 11
  • FreeTube version: 0.18.0

ChunkyProgrammer and others added 30 commits May 8, 2023 21:23
@ChunkyProgrammer
Allow using piped for comments
5d903ed
@ChunkyProgrammer
add piped playlist support
beb3e55
@ChunkyProgrammer
add piped settings + fallback when not supported
1ffcc55
@ChunkyProgrammer
fix comment and playlist fallbacks
98fdaa3
@ChunkyProgrammer
prevent same api from being used for backend + fallback
7550f59
@ChunkyProgrammer
fix displaying playlist thumbnails
379b593
@ChunkyProgrammer
Revert "fix displaying playlist thumbnails"
b232567 
This reverts commit 379b593.
@ChunkyProgrammer @absidue
format piped instances json
34f483c 
Co-Authored-By: absidue <[email protected]>
@ChunkyProgrammer
fix piped to yt image conversion, hide missing playlist data
7e5bb17
@ChunkyProgrammer
create ft-instance-selector component
5491ef6
@ChunkyProgrammer
hide dash on playlist info for piped
34a1706
@ChunkyProgrammer @PikachuEXE
Fix Invidious fallback for piped playlists
44e82ac 
Co-authored-by: PikachuEXE <[email protected]>
@ChunkyProgrammer @PikachuEXE
Fix incorrect toast message
c5244b0 
Co-Authored-By: PikachuEXE <[email protected]>
@ChunkyProgrammer @PikachuEXE
simplify v-if
b883d83 
Co-Authored-By: PikachuEXE <[email protected]>
@ChunkyProgrammer
Allow using piped for comments
5ef7627
@ChunkyProgrammer
add piped playlist support
17c7510
@ChunkyProgrammer
add piped settings + fallback when not supported
3633a86
@ChunkyProgrammer
fix comment and playlist fallbacks
3b4ee59
@ChunkyProgrammer
prevent same api from being used for backend + fallback
d5f9517
@ChunkyProgrammer
fix displaying playlist thumbnails
92a3bbd
@ChunkyProgrammer
Revert "fix displaying playlist thumbnails"
315e96b 
This reverts commit 379b593.
@ChunkyProgrammer @absidue
format piped instances json
a581bd0 
Co-Authored-By: absidue <[email protected]>
@ChunkyProgrammer
fix piped to yt image conversion, hide missing playlist data
632a7c8
@ChunkyProgrammer
create ft-instance-selector component
f109da2
@ChunkyProgrammer
hide dash on playlist info for piped
31704e0
@ChunkyProgrammer @PikachuEXE
Fix Invidious fallback for piped playlists
0801c07 
Co-authored-by: PikachuEXE <[email protected]>
@ChunkyProgrammer @PikachuEXE
Fix incorrect toast message
13d3acc 
Co-Authored-By: PikachuEXE <[email protected]>
@ChunkyProgrammer @PikachuEXE
simplify v-if
48601a6 
Co-Authored-By: PikachuEXE <[email protected]>
@ChunkyProgrammer
fix clear default instance, fix toast message
add031b
@ChunkyProgrammer
Merge branch 'piped-support' of https://github.com/ChunkyProgrammer/F…
5f92e07 
…reeTube into piped-support
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarmadileManteater MarmadileManteater MarmadileManteater left review comments

@absidue absidue absidue requested changes

@kommunarr kommunarr kommunarr left review comments

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left review comments

@PikachuEXE PikachuEXE Awaiting requested review from PikachuEXE

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
PR: merge conflicts / rebase needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @shellheim @absidue @kommunarr @MarmadileManteater