Fix premieres on the subscription page #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
previously approved these changes
Mar 3, 2023
auto-merge was automatically disabled
March 3, 2023 06:57
Pull request was converted to draft
github-actions
bot
removed
the
PR: waiting for review
|
Looks like the premiere date is shown incorrectly after loading from the subscriptions cache, I want to fix that too, so I've converted this to a draft, so that it doesn't accidentally get merged before that happens. |
github-actions
bot
added
the
PR: waiting for review
There was a problem hiding this comment.
it fixes it but there seems to be an bug that needs to be addressed. Should i create issue for them?
edit: dismiss the issue shown related to #3242 but do note the issue on the second half of the video
VirtualBoxVM_huFoQ7Xff0.mp4
|
pretty sure everything later on in the video is because of #3242 and subscribing to an errored channel (not sure why it's even showing the subscription button) |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 3, 2023
PikachuEXE
approved these changes
Mar 4, 2023
1 task
ChunkyProgrammer
approved these changes
Mar 5, 2023
github-actions
bot
removed
the
PR: waiting for review
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix premieres on the subscription page
Pull Request Type
Description
Currently if you are subscribed to a channel that has a premiere video, when you refresch your subscriptions on the local API without RSS, you will see that it says it was uploaded x hours ago and an error in the console.
This pull request fixes it.
Screenshots
Testing
Subscribe to https://www.youtube.com/@onetv4548 and refresh your subscriptions with the local API without using RSS.
Desktop