Adjust side-nav-more-options
to account for anchor style
#3097
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust
side-nav-more-options
to account for difference in style betweenrouter-link
anddiv
Pull Request Type
Description
Somewhat recently, the
side-nav-more-options
icons were changed to berouter-link
s instead ofdiv
s, but the style difference betweenrouter-link
anddiv
still needs to be accounted for becauserouter-link
s carry with them all of the styles of anchors. Due to this, the text in the more options menu is the primary link color and the background color is not visible on hover (due to the display being inline). This PR aims to address this by adding some of the styles thatdiv
s have to the.navOption
class in theside-nav-more-options
component.Screenshots
Testing
More
navbar item appears: (width < 678px).More
navbar item.More
are do not appear to be the primary link colorDesktop