Shorts tab on channel page #3093

KarateCowboy · 2023-01-18T20:58:09Z

Add 'Shorts' tab to the Channel page

Pull Request Type

Bugfix
Feature Implementation
Documentation
Other

Description

Adds the Shorts tab for a channel to the Channel Page. Allows for playing via direct or invidious api

Screenshots

Before:

After:

Testing

Find a channel which has Shorts and Subscribe to it.
View the Channels page, then click on that channel
The new "Shorts" tab should be visible. Click it
There should be a grid with Shorts in it.
Click any of the shorts. You should be taken to the Watch page and be able to watch the Short

github-actions · 2023-01-19T00:52:15Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

absidue · 2023-01-19T08:25:56Z

This PR doesn't actually implement the feature request that you mention in the Related issue section. As mentioned in #2476 (comment) that feature request is actually for the infinitely scrolling shorts tab, although there is an unrelated discussion towards the end of that thread that mentions the shorts tab on the channels page.
I'll remove it from the pull request description for you, so that it stays open until someone actually implements it.

absidue · 2023-01-19T08:36:55Z

src/renderer/components/ft-list-video/ft-list-video.js

@@ -393,7 +393,7 @@ export default Vue.extend({
        this.publishedText = this.data.publishedText
      }

-      if (typeof (this.data.publishedText) !== 'undefined' && this.data.publishedText !== null && !this.isLive) {
+      if ('publishedText' in this.data && !!this.data.publishedText && !this.isLive) {


This change can be simplified to this:

Suggested change

if ('publishedText' in this.data && !!this.data.publishedText && !this.isLive) {

if (this.data.publishedText && !this.isLive) {

KarateCowboy · 2023-01-19T23:24:01Z

Hi,

So, in issue #2476 there is quite a bit going on.

The opening post by a deleted user asks for a dedicated shorts tab but is ambiguous beyond that. We obviously cannot ask for clarification.
Then @ChunkyProgrammer speculates that the user may have wanted an infinite scrolling list of some type.
Then we see @efb4f5ff-1298-471a-8973-3d47447115dc saying there should be a shorts tab that is just like the subscriptions tab. All shorts, from all channels
I thought there was also a user asking for a shorts tab on the channels page. Is that what you removed?
Finally, there is @ChunkyProgrammer commenting that there should be a toggle to disable both shorts and streams

I see content for several stories in there:

A shorts tab on the channel page
a shorts page which includes aggregated shorts from all subscriptions
a streams tab on the channel page
an infinite scrolling loop of shorts with autoplay
the ability to disable shorts
the ability to disable streams

How about this for a plan of action: we use this PR as an MVP to get shorts, at all, out the door(item 1 on the list)? I can go and create separate stories for the rest, and flesh out the details plus input. Let me know your thoughts, everyone.

absidue · 2023-01-21T16:35:57Z

The only thing I edited was the description of this pull request, to remove the reference to a feature request for a different feature (See the screenshot below).

Why am I so sure that the original feature request is unrelated to the shorts tab on the channel page?
That feature request was opened in August, YouTube only split the videos tab up into the videos, shorts and live tabs in October/November. Additionally the requester asked for a dedicated shorts tab and Chunky pointed out that the YouTube has a dedicated infinitely scrollable shorts tab (visit https://www.youtube.com and click shorts in the sidebar), so it's highly likely that the requester meant that.

This pull request only implements the discussion that is going on below that feature request, not the actual feature request itself. I removed your "implements #number" text, so the feature request stays open until it is implemented.

I'm sorry that my words and actions came across as attacks, that wasn't my intention. My intention was just to point out that the feature that this pull request implements, is not the one in the feature request that you linked, so I removed your link to it. This pull request is completely fine (well a few code changes are needed before it gets merged, like fixing the code conflicts) as a pull request that implements the shorts tab on the channel page.

KarateCowboy · 2023-01-22T01:49:50Z

Hi absidue

Forgive me if the verbosity of my last post made it seem like I was being defensive. I did not interpret what you wrote as combative. There is much to this project which I am still learning: what code does what, who is active and coding, and who is keeping track of what. Because of that I decided to be very detailed about what I observe and am thinking. Also, I am excited and charged up to help out, so there is that energy.

What you are saying about Youtube splitting pieces versus the creation of the feature request makes perfect sense. I totally agree.

I will clean up the code conflicts. There are two outstanding things I see where I need some advise:

What do I need to do about i18n for the features, if anything?
My code is pointing to a git commit, per @ChunkyProgrammer 's advice. Do I need to wait for a new release, or is it ok to commit with the package.json pointing at a git branch/hash?

After that, what is the review, test, and release process?

ChunkyProgrammer

You are missing a string for 'This channel does not currently have any shorts' in the en-US locale file. Other than that i18n looks good.

The translations for other languages are done through Weblate and if a translation is missing in a language, it will fallback to en-US 😄

Pointing to the git branch should be fine for now (we'll be using YouTube.js in FreeTube's next release instead of yt-channel-info)

"Also, while the request mentioned the ability to hide shorts, I could find no such toggle. Perhaps I could add that on to this." sorry, I just didnt remember off the top of my head if that functionality was already implemented or not 😄 if you would like to add it, you can do it in a separate PR.

If you'd like to add the ability to load more shorts to this PR:
a continuation parameter can be added to the invidious call or you can call getChannelVideosMore with the shorts continuation

Let me know if you have any more questions. Thanks for opening a PR!

src/renderer/views/Channel/Channel.js

src/renderer/views/Watch/Watch.js

static/locales/en-US.yaml

KarateCowboy · 2023-01-28T20:28:47Z

I updated and took all of @ChunkyProgrammer 's suggestions. It appears that additional shorts are automatically loading as I scroll down the page. Hopefully it works the same for you. The only outstanding issue I see is the conflict in package.json between the released version of yt-channel-info. My code is pointing directly to a git commit.

Thanks for opening a PR!

Thank you for creating this application. And, thank you for facilitating my contribution.

ChunkyProgrammer · 2023-01-28T20:30:43Z

Would you be able to resolve the merge conflict as well @KarateCowboy ?

KarateCowboy · 2023-01-28T20:36:29Z

@ChunkyProgrammer Sure thing. It looks like I missed the part where you said it is OK to point to the git commit.

@absidue Sure thing. To replicate the error, remove the extra conditional. Then subscribe to the channel Julia Stunts. Then go to that channel via "Channels > Julia Maggio". Then click the shorts tab. Then the Short "Devil Hunters@WholeWheatPete @itsKingChris & @StellaChuu".

github-actions · 2023-01-28T20:37:19Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

package.json

efb4f5ff-1298-471a-8973-3d47447115dc · 2023-02-08T19:59:41Z

@KarateCowboy could u please upload the screenshots direct on GitHub instead of Dropbox

KarateCowboy · 2023-02-08T20:04:47Z

@KarateCowboy could u please upload the screenshots direct on GitHub instead of Dropbox

Done

efb4f5ff-1298-471a-8973-3d47447115dc · 2023-02-08T20:50:51Z

Noticed that the view count is off

KarateCowboy · 2023-02-10T06:32:34Z

Noticed that the view count is off

I looked and that's actually what is coming through from yt-channel-info. if you console.log the response in src/renderer/helpers/api/index.js you can see:

And the same Short on YT:

absidue · 2023-02-10T07:26:56Z

Could you please add the new tab to the tabInfoValues array on the channel page. That array is used so you can cycle the focus through the tabs by pressing the left and right arrow keys.

ChunkyProgrammer · 2023-02-12T19:36:13Z

PS: This YouTube.js stuff --- how close to arrival is it?

The current plan:
Once LuanRT/YouTube.js#309 gets merged then #3143 will need some updates + testing + review and then the youtubei.js migration will be merged when approved.

KarateCowboy · 2023-02-12T21:22:31Z

PS: This YouTube.js stuff --- how close to arrival is it?

The current plan: Once LuanRT/YouTube.js#309 gets merged then #3143 will need some updates + testing + review and then the youtubei.js migration will be merged when approved.

Understood. I will keep an eye on that and then update accordingly.

github-actions · 2023-02-27T01:25:21Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

efb4f5ff-1298-471a-8973-3d47447115dc · 2023-03-02T08:16:08Z

@KarateCowboy #3143 is merged :)

KarateCowboy · 2023-03-04T00:01:05Z

@KarateCowboy #3143 is merged :)

I'll get to it this weekend!

efb4f5ff-1298-471a-8973-3d47447115dc · 2023-03-11T07:11:34Z

@KarateCowboy #3143 is merged :)

I'll get to it this weekend!

umm this weekend @KarateCowboy ?

KarateCowboy · 2023-03-11T07:22:50Z

Sorry. I looked at it a little last weekend but had my time cut short because I started a new job. This weekend, however, I have more time. Even if it's my birthday. :D Mar 11, 2023 01:11:53 efb4f5ff-1298-471a-8973-3d47447115dc ***@***.***>:

…

@KarateCowboy[https://github.com/KarateCowboy] #3143[#3143] is merged :) I'll get to it this weekend! umm this weekend @KarateCowboy[https://github.com/KarateCowboy] ? — Reply to this email directly, view it on GitHub[#3093 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AACYFICI4RB2P44KJR65DS3W3QQTDANCNFSM6AAAAAAT7RTW3U]. You are receiving this because you were mentioned.[Tracking image][https://github.com/notifications/beacon/AACYFIHHSSISB5YJ3GHSQ43W3QQTDA5CNFSM6AAAAAAT7RTW3WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSXJ7HHU.gif]

absidue · 2023-03-11T13:41:58Z

@KarateCowboy feel free to use #3273 as an inspiration (it adds support for the live tab).

KarateCowboy · 2023-03-15T02:03:28Z

pulled in latest. hacking away a little tonight

ChunkyProgrammer · 2023-04-03T22:11:08Z

Hi @KarateCowboy do you still plan on working on this? Note: invidious shorts should work once iv-org/invidious#3700 is merged

KarateCowboy · 2023-04-05T22:20:31Z

Hi @KarateCowboy do you still plan on working on this? Note: invidious shorts should work once iv-org/invidious#3700 is merged

Hey hey. Thanks for the bump. I'll hit it up over the holiday weekend. Sunday night

absidue · 2023-04-06T06:59:33Z

Hi @KarateCowboy
Glad to hear that you are picking this up again :). To keep this pull request small and on topic, please leave the addition of a test framework and the refactor out of this pull request. If you want to add it, please do so in a different pull request, instead of cramming multiple things into one pull request. Keeping it simple, makes it easier and faster to review.

efb4f5ff-1298-471a-8973-3d47447115dc · 2023-05-15T10:23:13Z

Closing, this is implemented in #3533

github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 18, 2023

FreeTubeBot enabled auto-merge (squash) January 18, 2023 20:58

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 19, 2023

auto-merge was automatically disabled January 19, 2023 04:48
Head branch was pushed to by a user without write access

KarateCowboy force-pushed the channel-shorts-tab branch from 69c3912 to db840bc Compare January 19, 2023 04:48

FreeTubeBot enabled auto-merge (squash) January 19, 2023 04:48

absidue reviewed Jan 19, 2023

View reviewed changes

auto-merge was automatically disabled January 22, 2023 21:28
Head branch was pushed to by a user without write access

KarateCowboy force-pushed the channel-shorts-tab branch from db840bc to 9966250 Compare January 22, 2023 21:28

FreeTubeBot enabled auto-merge (squash) January 22, 2023 21:28

auto-merge was automatically disabled January 22, 2023 21:30
Head branch was pushed to by a user without write access

KarateCowboy force-pushed the channel-shorts-tab branch from 9966250 to c7ebf22 Compare January 22, 2023 21:30

FreeTubeBot enabled auto-merge (squash) January 22, 2023 21:30

ChunkyProgrammer reviewed Jan 23, 2023

View reviewed changes

auto-merge was automatically disabled January 28, 2023 20:22
Head branch was pushed to by a user without write access

FreeTubeBot enabled auto-merge (squash) January 28, 2023 20:22

github-actions bot removed the PR: merge conflicts / rebase needed label Jan 28, 2023

github-advanced-security bot found potential problems Jan 28, 2023

View reviewed changes

package.json Fixed Show fixed Hide fixed

auto-merge was automatically disabled January 28, 2023 20:45
Head branch was pushed to by a user without write access

KarateCowboy requested review from ChunkyProgrammer and absidue and removed request for PikachuEXE and ChunkyProgrammer February 8, 2023 19:41

efb4f5ff-1298-471a-8973-3d47447115dc added the PR: WIP label Feb 12, 2023

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Feb 27, 2023

efb4f5ff-1298-471a-8973-3d47447115dc mentioned this pull request May 14, 2023

Implement the shorts tab on channel pages #3533

Merged

1 task

efb4f5ff-1298-471a-8973-3d47447115dc closed this May 15, 2023

auto-merge was automatically disabled May 15, 2023 10:23
Pull request was closed

github-actions bot removed PR: merge conflicts / rebase needed PR: WIP labels May 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shorts tab on channel page #3093

Shorts tab on channel page #3093

KarateCowboy commented Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023

absidue commented Jan 19, 2023

absidue Jan 19, 2023

KarateCowboy commented Jan 19, 2023 •

edited

Loading

absidue commented Jan 21, 2023

KarateCowboy commented Jan 22, 2023 •

edited

Loading

ChunkyProgrammer left a comment

KarateCowboy commented Jan 28, 2023 •

edited

Loading

ChunkyProgrammer commented Jan 28, 2023 •

edited

Loading

KarateCowboy commented Jan 28, 2023

github-actions bot commented Jan 28, 2023

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 8, 2023

KarateCowboy commented Feb 8, 2023

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 8, 2023

KarateCowboy commented Feb 10, 2023

absidue commented Feb 10, 2023

ChunkyProgrammer commented Feb 12, 2023 •

edited

Loading

KarateCowboy commented Feb 12, 2023

github-actions bot commented Feb 27, 2023

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 2, 2023 •

edited

Loading

KarateCowboy commented Mar 4, 2023

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 11, 2023

KarateCowboy commented Mar 11, 2023 via email

absidue commented Mar 11, 2023

KarateCowboy commented Mar 15, 2023

ChunkyProgrammer commented Apr 3, 2023

KarateCowboy commented Apr 5, 2023

absidue commented Apr 6, 2023

efb4f5ff-1298-471a-8973-3d47447115dc commented May 15, 2023

	if ('publishedText' in this.data && !!this.data.publishedText && !this.isLive) {
	if (this.data.publishedText && !this.isLive) {

Shorts tab on channel page #3093

Shorts tab on channel page #3093

Conversation

KarateCowboy commented Jan 18, 2023 • edited Loading

Add 'Shorts' tab to the Channel page

Pull Request Type

Description

Screenshots

Before:

After:

Testing

github-actions bot commented Jan 19, 2023

absidue commented Jan 19, 2023

absidue Jan 19, 2023

Choose a reason for hiding this comment

KarateCowboy commented Jan 19, 2023 • edited Loading

absidue commented Jan 21, 2023

KarateCowboy commented Jan 22, 2023 • edited Loading

ChunkyProgrammer left a comment

Choose a reason for hiding this comment

KarateCowboy commented Jan 28, 2023 • edited Loading

ChunkyProgrammer commented Jan 28, 2023 • edited Loading

KarateCowboy commented Jan 28, 2023

github-actions bot commented Jan 28, 2023

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 8, 2023

KarateCowboy commented Feb 8, 2023

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 8, 2023

KarateCowboy commented Feb 10, 2023

absidue commented Feb 10, 2023

ChunkyProgrammer commented Feb 12, 2023 • edited Loading

KarateCowboy commented Feb 12, 2023

github-actions bot commented Feb 27, 2023

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 2, 2023 • edited Loading

KarateCowboy commented Mar 4, 2023

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 11, 2023

KarateCowboy commented Mar 11, 2023 via email

absidue commented Mar 11, 2023

KarateCowboy commented Mar 15, 2023

ChunkyProgrammer commented Apr 3, 2023

KarateCowboy commented Apr 5, 2023

absidue commented Apr 6, 2023

efb4f5ff-1298-471a-8973-3d47447115dc commented May 15, 2023

KarateCowboy commented Jan 18, 2023 •

edited

Loading

KarateCowboy commented Jan 19, 2023 •

edited

Loading

KarateCowboy commented Jan 22, 2023 •

edited

Loading

KarateCowboy commented Jan 28, 2023 •

edited

Loading

ChunkyProgrammer commented Jan 28, 2023 •

edited

Loading

ChunkyProgrammer commented Feb 12, 2023 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 2, 2023 •

edited

Loading