fix error when searching #2960
Merged
fix error when searching #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Dec 14, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 14, 2022
absidue
approved these changes
Dec 14, 2022
github-actions
bot
removed
the
PR: waiting for review
|
Even with this PR, if there are no search suggestions, searching by pressing enter doesn't work, it does work if you click the search button. If you enter a URL e.g. |
|
searching by pressing enter does work for me BUT only when search suggestion appears |
4 tasks
|
Opened #2966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error when searching
Pull Request Type
Description
Error introduced in #2943
If you click enter without selecting an option in the list then an error will occur
Testing
Write something in search bar, click enter without hovering over any of the options
Desktop