Copy in-app links as YouTube links

[absidue]

Copy in-app links as YouTube links

Pull Request Type

• Feature Implementation

Related issue

closes #2479

Description

Currently all links in FreeTube, in-app and external ones, have the "Copy Link" context menu entry. This PR changes it to only show up on external links and certain in-app ones, to make it useful on the in-app ones it also transforms them into their YouTube equivalents. This means that you can copy the link to a video just by right clicking on it in the search results.

Testing

1. Right click on menu items in the side bar, "Copy Link" should only show up for the list of subscribed channels
2. Right click on videos, channels and playlists in channels, search results, playlists, up next and trending
3. Right click on channel name and image on the watch and playlist pages

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: 0.18.0

[ChunkyProgrammer]

I'm guessing the & is a typo?

[absidue]

No, it makes that context menu entry activatable by clicking on it or pressing the k key while the context menu is open. As electron-context-menu does the same (https://github.com/sindresorhus/electron-context-menu/blob/main/index.js#L167) I thought it would be a good idea to copy it, so that the behaviour is the same (I should probably add it for the Select All option as well).

[ChunkyProgrammer]

Ahhh cool, didnt know that

[PikachuEXE]

Please add code comment for it :S

[PikachuEXE]

Copy Link or Copy Youtube Link (and later might add Copy Invidious Link)?

[absidue]

I can definitely do Copy Link for external links, Copy YouTube Link for in-app links that can be converted to YouTube links (will hide the Copy Link one for those).

However doing an Invidious one is not going to be clean. The current Invidious instance is stored in the individual renderer processes, each renderer process (browser window) can have a diffferent invidious instance, unlike renderer to main ipc, you can't send replies when doing main to renderer, the only option is to send a separate ipc message to a different handler, so not what we want for the context menu.

[PikachuEXE]

In that case Copy Link is good enough

[ChunkyProgrammer]

I can definitely do Copy Link for external links, Copy YouTube Link for in-app links that can be converted to YouTube links (will hide the Copy Link one for those).

However doing an Invidious one is not going to be clean. The current Invidious instance is stored in the individual renderer processes, each renderer process (browser window) can have a diffferent invidious instance, unlike renderer to main ipc, you can't send replies when doing main to renderer, the only option is to send a separate ipc message to a different handler, so not what we want for the context menu.

For invidious, you could just need to use the link "https://redirect.invidious.io/", that way anyone that goes to that link can choose which instance they want 🙂