Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Show save icon in thumbnail on hover #1746 #2648

Closed
wants to merge 1 commit into from

Conversation

rolandoangulo
Copy link

@rolandoangulo rolandoangulo commented Sep 30, 2022

Feat: Show save icon in thumbnail on hover

Pull Request Type

  • Feature Implementation

Related issu

closes #1746

Description

Only show the favorite icon on hover

Screenshots

Testing

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@PrestonN PrestonN enabled auto-merge (squash) September 30, 2022 20:23
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 30, 2022
@efb4f5ff-1298-471a-8973-3d47447115dc

Hi there, i understand that this is an easy to understand PR but please do fill out the template!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does only work when u hover in the top right corner of the thumbnail. I think its better to show when u hover over any position of the thumbnail

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 30, 2022
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this comment as it was too mean.

@absidue
Copy link
Member

absidue commented Oct 1, 2022

Sorry my comment earlier was a bit harsh. I recommend looking at the ft-list-video component instead of the ft-icon-button component, that way your changes will only affect the favourites button as well as being able to fix the issue that @efb4f5ff-1298-471a-8973-3d47447115dc noticed while testing.

P.S. you should be able to make it show and hide the favourites button when the thumbnail wrapper is being hovered over, purely in CSS without needing much code for it.

@ChunkyProgrammer ChunkyProgrammer changed the title Update ft-icon-button.sass Feat: Show save icon in thumbnail on hover #1746 Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 14 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show save icon in thumbnail on hover
3 participants