Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new extension to the list and small fixes #156

Merged
merged 12 commits into from
Dec 19, 2024

Conversation

MStankiewiczOfficial
Copy link
Contributor

  • Added the RedirectTube extension to the list.
  • Added that Privacy Redirect and LibRedirect open FreeTube automatically when you open a link from YouTube.
  • Fixed the Privacy Redirect link for Firefox so that it does not open the page in English, but in the browser language (as in the other links).
  • In the warning about extensions not working on portable Linux builds, changed the singular to plural.

- Added the RedirectTube extension to the list.
- Added that Privacy Redirect and LibRedirect open FreeTube automatically when you open a link from YouTube.
- Fixed the Privacy Redirect link for Firefox so that it does not open the page in English, but in the browser language (as in the other links).
- In the warning about extensions not working on portable Linux builds, changed the singular to plural.
PikachuEXE
PikachuEXE previously approved these changes Dec 17, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should opt for a route that keeps everything organized for the reader

You can use the following extensions to open YouTube links directly in FreeTube:

  • Privacy Redirect
  • LibRedirect
  • RedirectTube

Privacy Redirect and LibRedirect automatically redirect YouTube links to FreeTube. To make them work, you’ll need to enable the relevant option in the advanced settings of each extension.

RedirectTube, on the other hand, doesn’t automatically open YouTube links in FreeTube. Instead, it adds buttons to the toolbar and context menu, which you can click to open videos in FreeTube manually.

  • Download Privacy Redirect for ...
  • Download LibRedirect for...
  • Download RedirectTube for...

@MStankiewiczOfficial
Copy link
Contributor Author

Good idea. In addition, I can according to issue #138 remove Privacy Redirect from the list. What do you think?

@MStankiewiczOfficial
Copy link
Contributor Author

I just got another idea that it might be worth changing the names of the browsers for which you want to download to the source from which you are downloading, i.e. for Mozilla Firefox to from Mozilla Add-ons and for Google Chrome to from Chrome Web Store. This matters because extensions, for example, from the Chrome Web Store work not only in Google Chrome, but also on other browsers, such as Microsoft Edge and Opera.

@efb4f5ff-1298-471a-8973-3d47447115dc

Good idea. In addition, I can according to issue #138 remove Privacy Redirect from the list. What do you think?

Best to remove it. I forgot that it was a thing i needed to do. The project has been abandoned for a long time now.

I just got another idea that it might be worth changing the names of the browsers for which you want to download to the source from which you are downloading, i.e. for Mozilla Firefox to from Mozilla Add-ons and for Google Chrome to from Chrome Web Store. This matters because extensions, for example, from the Chrome Web Store work not only in Google Chrome, but also on other browsers, such as Microsoft Edge and Opera.

Thats a good point. The only issue i see with this is that those terms may be less recognizable then the actual browser name and therefore will leave people confused

What about something like: Download ... for Chrome/Chromium based browsers

Download ... for FireFox based browsers

- Completely rebuilt the content of the site
- Removed Privacy Redirect extension from the site (FreeTubeApp#138)
auto-merge was automatically disabled December 17, 2024 12:35

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 17, 2024 12:36
- Completely rebuilt the content of the site
- Removed Privacy Redirect extension from the site (FreeTubeApp#138)
- Typos corrected
auto-merge was automatically disabled December 17, 2024 12:39

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 17, 2024 12:39
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled December 17, 2024 12:48

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 17, 2024 12:49
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled December 17, 2024 12:52

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 17, 2024 12:52
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled December 17, 2024 19:14

Head branch was pushed to by a user without write access

Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 17, 2024 19:14
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled December 17, 2024 19:15

Head branch was pushed to by a user without write access

Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 17, 2024 19:15
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled December 17, 2024 19:15

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 17, 2024 19:15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM thank you for putting al the work in and creating the extension. I let the others review and approve this as i have co-contributed in this PR

auto-merge was automatically disabled December 18, 2024 10:55

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 18, 2024 10:55
@FreeTubeBot FreeTubeBot merged commit 2ac3a0a into FreeTubeApp:master Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants