Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added macOS shortcut documentation #112

Merged
merged 10 commits into from
Dec 11, 2023
Merged

Added macOS shortcut documentation #112

merged 10 commits into from
Dec 11, 2023

Conversation

OblackatO
Copy link
Contributor

As promised the documentation for macOS shortcut.

For some reason the images aren't appearing... I added two images in ../images/, where ../ is the relative path to the usage folder.

Could you please fix this or move the images to where they should be at?
I also tried to create an usage_images folder under usage, but that also didn't work.

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 1, 2023 22:30
PikachuEXE
PikachuEXE requested changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this and it works locally

Doc for using images/assets in jekyll

Please also change the alt text to something useful (just need short description)

usage/macos-shortcut.md Outdated Show resolved Hide resolved
usage/macos-shortcut.md Outdated Show resolved Hide resolved
@PikachuEXE
Copy link
Contributor

Preview for my local with image fix
image
image

auto-merge was automatically disabled December 2, 2023 07:50

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 2, 2023 07:50
@OblackatO
Copy link
Contributor Author

@PikachuEXE Thanks for help with the pictures. It also worked for me locally with your fix.

I think the MR should be good to go now...

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Maybe we add a link for users that are looking at https://docs.freetubeapp.io/usage/browser-extension/ to this new page so they dont miss out on this info

PikachuEXE
PikachuEXE requested changes Dec 4, 2023
View reviewed changes
usage/macos-shortcut.md Outdated Show resolved Hide resolved
@OblackatO @efb4f5ff-1298-471a-8973-3d47447115dc
Update usage/macos-shortcut.md
9551aba 
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled December 4, 2023 20:10

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 4, 2023 20:11
@OblackatO @efb4f5ff-1298-471a-8973-3d47447115dc
Update usage/macos-shortcut.md
c1e8123 
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled December 4, 2023 20:11

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 4, 2023 20:11
@OblackatO @efb4f5ff-1298-471a-8973-3d47447115dc
Update usage/macos-shortcut.md
1f2c9d9 
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled December 4, 2023 20:12

Head branch was pushed to by a user without write access

@OblackatO @efb4f5ff-1298-471a-8973-3d47447115dc
Update usage/macos-shortcut.md
4c83953 
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 4, 2023 20:12
@OblackatO @efb4f5ff-1298-471a-8973-3d47447115dc
Update usage/macos-shortcut.md
91ac642 
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled December 4, 2023 20:13

Head branch was pushed to by a user without write access

@OblackatO @efb4f5ff-1298-471a-8973-3d47447115dc
Update usage/macos-shortcut.md
871000b 
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 4, 2023 20:13
@OblackatO @efb4f5ff-1298-471a-8973-3d47447115dc
Update usage/macos-shortcut.md
8e8238d 
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled December 4, 2023 20:13

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 4, 2023 20:13
auto-merge was automatically disabled December 4, 2023 20:32

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 4, 2023 20:32
@OblackatO OblackatO requested a review from PikachuEXE December 4, 2023 21:29
@FreeTubeBot FreeTubeBot merged commit cf22863 into FreeTubeApp:master Dec 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue Awaiting requested review from absidue

@kommunarr kommunarr Awaiting requested review from kommunarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OblackatO @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot