Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker setup rework #58

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Docker setup rework #58

merged 6 commits into from
Jan 23, 2024

Conversation

CypressXt
Copy link
Contributor

Hi Hi,

Not sure where the project currently lays regarding the docker support but here could be the begging of a plan for it.
An option would be to "micro-service" it, this PR goes into this direction
If you find it useful I can also rework the other FreeTAKTeam projects to have an easy docker compose stack that could look like this:

version: '3'

Services:
    tak-server: {}
    tak-server-ui: {}
    tak-server-map: {}

How would you feel about it ?

@brothercorvo
Copy link
Contributor

@RadioAndrea please review and comment

compose.yaml Outdated
# - 9000:9000
# - 19023:19023

tak-server-ui:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change this to show that this is Free TAK Server and not just the standard TAK server to prevent confusion with the government version

@RadioAndrea
Copy link
Contributor

I like this, just the service name I think should be changed to something like free-tak-server-ui or fts-ui to ensure delineation from the US Gov tak offering, as they are now also providing some docker images.

Presumably someone may operate both and we should, by default, try to prevent confusion.

Compose services have been renamed to avoid confusion with the Tak.gov TakServer
@CypressXt
Copy link
Contributor Author

Make sense 👌 thanks for the review !

@brothercorvo brothercorvo requested a review from naman108 January 8, 2024 19:47
@brothercorvo
Copy link
Contributor

@naman108 please review for impacts on the rest of FTS

compose.yaml Outdated Show resolved Hide resolved
@RadioAndrea
Copy link
Contributor

I approve, but haven't heard from @naman108 yet.
Once this is merged in, I'll also move the changes to the FTS-hub for the prodbuilds

@naman108
Copy link
Contributor

All changes to config.py look good, so that's an ok on the code side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants