-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker setup rework #58
Conversation
@RadioAndrea please review and comment |
compose.yaml
Outdated
# - 9000:9000 | ||
# - 19023:19023 | ||
|
||
tak-server-ui: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change this to show that this is Free TAK Server and not just the standard TAK server to prevent confusion with the government version
I like this, just the service name I think should be changed to something like free-tak-server-ui or fts-ui to ensure delineation from the US Gov tak offering, as they are now also providing some docker images. Presumably someone may operate both and we should, by default, try to prevent confusion. |
Compose services have been renamed to avoid confusion with the Tak.gov TakServer
Make sense 👌 thanks for the review ! |
@naman108 please review for impacts on the rest of FTS |
I approve, but haven't heard from @naman108 yet. |
All changes to config.py look good, so that's an ok on the code side. |
Hi Hi,
Not sure where the project currently lays regarding the docker support but here could be the begging of a plan for it.
An option would be to "micro-service" it, this PR goes into this direction
If you find it useful I can also rework the other FreeTAKTeam projects to have an easy docker compose stack that could look like this:
How would you feel about it ?