Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freebsd support #779

Merged
merged 15 commits into from
Mar 5, 2016
Merged

Freebsd support #779

merged 15 commits into from
Mar 5, 2016

Conversation

antenore
Copy link
Member

@antenore antenore commented Mar 2, 2016

This PR adds support to FreeBSD

@giox069 @weberhofer

When you have time, can you please test this? (works only with FreeRDP 88fa29c as daylight is not implemented in time.h in FreeBSD)

To be compiled with -DHAVE_LIBAPPINDICATOR=off on FreeBSD

@akallabeth is aware. I'm also thinking how to solve it. Should be fixed by FreeRDP/FreeRDP#3179

@antenore
Copy link
Member Author

antenore commented Mar 2, 2016

Updated PR description

@antenore
Copy link
Member Author

antenore commented Mar 2, 2016

@giox069 I'm not sure if the reconnect patch will work (on linux) after this PR, that's why I'm asking to test (try an ssh connection)

@giox069
Copy link
Contributor

giox069 commented Mar 2, 2016

@antenore: currently the autoreconnect feature only works with non-ssh tunnelled connections.
The lines which sets sockets timeout are only intended to better detect a ssh tunnel timeout/drop, and are not currently related to the autoreconnect feature, and I don't think your modification will break something.
I will test this PR later.

@antenore
Copy link
Member Author

antenore commented Mar 2, 2016

Thanks.
I'm aware of it, I was asking because on FreeBSD I've a problem with SSH (after my modifications), even with a normal ssh connection and I was wondering if it was related, somehow to these changes, but effectively is not, I've just tested on Fedora.

@giox069
Copy link
Contributor

giox069 commented Mar 2, 2016

@antenore: I have tested this PR on Ubuntu, both with and without ssh, and I did a autoreconnect test. All of this is working. Now I'm testing on FreeBSD 10.2, be patient :)

giox069 added a commit that referenced this pull request Mar 5, 2016
@giox069 giox069 merged commit b6d0b42 into next Mar 5, 2016
@antenore antenore deleted the freebsd branch March 20, 2016 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants