Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authors #1565

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Update authors #1565

merged 1 commit into from
Apr 12, 2018

Conversation

antenore
Copy link
Member

Added @amtlib-dot-dll to the authors/contributors list

I've also push a commit directhly in next that fixes an error on the flatpak build, that probably prevent Remmina to be published on the fluthub site.

appstream-util validate ~/.local/share/flatpak/app/org.remmina.Remmina/current/active/files/share/appdata/org.remmina.Remmina.appdata.xml
 style-invalid         : Too many <screenshot> tags, maximum is 5
url-not-found         : <screenshot> url not found [https://freerdp.github.io/Remmina/images/appdata/main-en.png]
Validation of files failed

@amtlib-dot-dll do we have to tag a new version? (I hope not!) can you kindly do whatever is needed to publish the new version with the commit ref of this PR?

Thanks in advance!!! BTW do you mind contacting me by email? It's in the about dialog.

@antenore antenore merged commit bb7f020 into next Apr 12, 2018
@antenore antenore removed the review label Apr 12, 2018
@amtlib-dot-dll
Copy link
Contributor

Thanks for adding me to the authors list!

I don't think that we need to tag a new version. Look v1.2.0-rcgit.29...next there are just commits about flatpak and snap, with one commit about translation and one commit about TCP socket. There are too few new things for such a new tag 😂

BTW, now that there are also more than 5 screenshots in https://github.com/FreeRDP/Remmina/blob/v1.2.0-rcgit.29/remmina/desktop/appdata.xml, why were the builds in flathub.org successful? 🤔

(Contacting you by email leaks my real email address 😜)

@antenore
Copy link
Member Author

(Contacting you by email leaks my real email address 😜)

It's just that I don't know how to get in touch with you except with issues and problems 🙄

@antenore antenore deleted the metada branch April 13, 2018 21:10
@amtlib-dot-dll
Copy link
Contributor

amtlib-dot-dll commented May 5, 2018

I sent you an email @antenore ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants