Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snap] Use the new desktop, desktop-legacy and wayland interfaces #1306

Merged
merged 1 commit into from
Oct 11, 2017
Merged

[snap] Use the new desktop, desktop-legacy and wayland interfaces #1306

merged 1 commit into from
Oct 11, 2017

Conversation

kenvandine
Copy link
Contributor

Use the new desktop, desktop-legacy and wayland interfaces introduced in snapd 2.28. Also build freerdp with wayland support. This fixes the
snap to work on Ubuntu Desktop 17.10 with the default session using
wayland.

snapd 2.28.  Also build freerdp with wayland support.  This fixes the
snap to work on Ubuntu Desktop 17.10 with the default session using
wayland.
@antenore
Copy link
Member

Thanks! How does it work for those who don't want or don't have Wayland? Any impacts?

@kenvandine
Copy link
Contributor Author

No impact on usage on xorg. The desktop interfaces allow access to x11 interfaces. As a note, if users try to install this on a system with an older snapd, it will warn about the missing interfaces but still succeeds and will work fine.

@antenore
Copy link
Member

Cool! Let's merge it then.
@giox069

@antenore
Copy link
Member

I'll add you to the contributors before the next release

@kenvandine
Copy link
Contributor Author

When do you think a build of the snap will end up in the snap store? The current version doesn't work in the wayland session, which is the default for 17.10 which will be released next week.

@giox069 giox069 merged commit 3d00a0c into FreeRDP:next Oct 11, 2017
@giox069
Copy link
Contributor

giox069 commented Oct 12, 2017

@kenvandine the updated build should be available on the "edge" snap channel, but I cannot check. I think it will be available on the stable channel when we release version 1.2.0-rcgit.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants