Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix english typos as per #1040 #1088

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Fix english typos as per #1040 #1088

merged 1 commit into from
Jan 31, 2017

Conversation

antenore
Copy link
Member

@DevDef can you please provide more context for the "resolution" typo?

resolution → definition (resolution is a number of points or pixels per surface unit, i.e DPI and PPI)

Thanks

@DevDef
Copy link
Contributor

DevDef commented Jan 13, 2017

In the following strings, for example:

#: remmina/src/remmina_file_editor.c:460 remmina/src/remmina_pref_dialog.c:79
#: remmina/ui/remmina_preferences.glade:250
msgid "Resolutions"
msgstr ""

#: remmina/src/remmina_file_editor.c:460 remmina/src/remmina_pref_dialog.c:79
msgid "Configure the available resolutions"
msgstr ""

#: remmina/src/remmina_file_editor.c:478
msgid "Resolution"
msgstr ""

#: remmina/src/remmina_connection_window.c:1738
msgid "Resize the window to fit in remote resolution"
msgstr ""

I think that the correct word is definition, like in high definition TV (i.e. number of pixels for a display), not resolution. The resolution is the number of pixels per surface unit (i.e. PPI pixel per inch). Though, this is a very current wrong usage of the word resolution…

@antenore
Copy link
Member Author

https://en.wikipedia.org/wiki/Display_resolution
Even if the usage is wrong it's globally accepted/used, so I'm afraid that changing it could have a bad effect.

I cannot decide myself, @giox069 , @ic3d what do you think?

@giox069
Copy link
Contributor

giox069 commented Jan 13, 2017

Also: https://en.wikipedia.org/wiki/Graphics_display_resolution
I agree with the fact that "resolution" has the alternative meaning of PPI (and in physics the meaning of resolution is closer to PPI than widthxheight).
But in the last 20 years I have almost never seen a technical document saying "your monitor has a 1024x768 definition". Also try to google for 1024x768 (or 1920x1080) definition and you will find almost nothing which concatenates the two search term.
All documents I have found in my life and I can find on google uses the word "resolution" to describe width and height in quantity of pixels.

@DevDef
Copy link
Contributor

DevDef commented Jan 13, 2017

So it’s a semantic slipping. ;-)
All right guys, let it be!

@antenore
Copy link
Member Author

Merging. I've even forgot about his.

@antenore antenore merged commit 3887024 into next Jan 31, 2017
@antenore antenore deleted the english_typos branch February 1, 2017 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants