Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for Windows and the OPC UA server #312

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Magnulas
Copy link

This pull request should fix the following issues:

Magnus Raunio added 4 commits May 16, 2018 13:04
uri_facade_win.cpp now includes uri_facade_lin.cpp since the Linux version is compatible with the Windows version as far as I can tell.
… OPC UA server to handle requests that were too large for the previous buffer size.
… when a non-existing node or attribute were added as a monitored item. Now the appropiate OPC UA status code should be returned instead.

Created a specific runtime exception for when a error defined by a OPC UA status code occures.
Modified cmake build script for MSVC targets to make Visual Studio output .lib files when building shared libraries.
@cenit
Copy link

cenit commented Mar 23, 2019

Hi @Magnulas,
Thanks for your contributions. I did something similar in some parts to bring freeopcua to vcpkg: https://github.com/Microsoft/vcpkg/tree/master/ports/freeopcua
Since we aim for a very stable release, can I ask you if the other parts of your patches are still required? If you have time, would you mind try it and contribute the necessary patchset also there?

@Magnulas
Copy link
Author

Hi @cenit,
I’ve looked at the patches you made and compared them to my own and I can’t see anything else that would be needed for building freeopcua for Windows. I tested building free opcua with vcpkg and VS2017, and I didn’t encounter any problems with freeopcua when linking it to my project.

I’m however running my opc ua server as a service, which is why I suggested using the linux version of uri_facade_*.cpp in the pull request, as it is compatible with Windows.

@cenit
Copy link

cenit commented Mar 28, 2019

Ok, good to know that Linux version is compatible also with windows. Happy to know that you can use vcpkg port of freeopcua without any problem. Please let me know if you encounter any, and you are very welcome to do a PR also there just in case

@valeria2706
Copy link

Hi @cenit,
I’ve looked at the patches you made and compared them to my own and I can’t see anything else that would be needed for building freeopcua for Windows. I tested building free opcua with vcpkg and VS2017, and I didn’t encounter any problems with freeopcua when linking it to my project.

I’m however running my opc ua server as a service, which is why I suggested using the linux version of uri_facade_*.cpp in the pull request, as it is compatible with Windows.

Hi @Magnulas , I used the patch you provided and vcpkg however it does not work for me. I have these following errors while building example_server. Can you help me take a look? Can't appreciate it more.
image

@Magnulas
Copy link
Author

Magnulas commented Apr 1, 2020

Hi @valeria2706,

Try casting the doubles to unsigned longs using static_cast. That's what they're doing in the latest version of the master branch for freeopcua. For the commit I created this pull request for the doubles were note cast. I assume they require a cast with a later version of boost. So if you clone the latest version of the master branch and merge it with my changes it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants