Switch to html-webpack-plugin 4.x #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmz
reviewed
Jan 2, 2021
| @@ -157,5 +160,5 @@ html(lang='en') | |||
| } | |||
| })(window, document); | |||
|
|
|||
| script(src=htmlWebpackPlugin.files.chunks.app.entry) | |||
| script(src=htmlWebpackPlugin.files.chunks.common.entry) | |||
| script(src=htmlWebpackPlugin.files.js[1]) | |||
There was a problem hiding this comment.
А по именам тут никак нельзя к чанкам обращаться?
There was a problem hiding this comment.
В этом и суть. Поэтому я долго не обновлялся. Надо попробовать. Но кажется там были какие-то принципиальные сложности
Возможно получится
There was a problem hiding this comment.
Да, выпилили напрочь: jantimon/html-webpack-plugin#1369. В данных я не вижу никаких намёков на имена.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use modern version of https://github.com/jantimon/html-webpack-plugin
It is not fully backwards-compatible (that's why we postponed the switch for so long). How can we verify that it works properly? My manual tests are successful