Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(New) Translate javascript-algorithms-and-data-structures-projects #48

Open
wants to merge 4 commits into
base: translate
Choose a base branch
from

Conversation

LynnLian
Copy link

@LynnLian LynnLian commented Jul 31, 2018

翻译章节

《算法和数据结构——实战》

变更文件

  • javascript-algorithms-and-data-structures-projects.json

  • javascript-algorithms-and-data-structures-projects.md

翻译进度

  • 100%

  • 100%

@LynnLian
Copy link
Author

@wudifeixue @S1ngS1ng @huluoyang FYA

(原pr有其他人的commit,所以新建pr)

Copy link

@wudifeixue wudifeixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

别的看起来都挺好的,<code>加上去就好了

"<code>cid</code>是包含货币面值的二维数组。",
"函数<code>checkCashRegister()</code>必须返回含有<code>status</code>键值和<code>change</code>键值的对象。",
"如果收银机內的金额少于应找回的零钱数,或者你无法返回确切的数目时,返回<code>{status: \"INSUFFICIENT_FUNDS\", change: []}</code>。",
"如果收银机內的金额等于应找回的零钱数,返回{status: \"CLOSED\", change: [...]}</code>,其中<code>change</code>键值是收银机內的金额。",
Copy link

@wudifeixue wudifeixue Jul 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个错误太难抓了。。我搜索了<code>和</code>发现全局总数不正确。。就知道哪里出错了。
看原文Return后面有一个<code>但是翻译后的“如果收银机內的金额等于应找回的零钱数,返回“后面的<code>丢掉了。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

点赞!! 用这个方法做检查非常赞 :)

最后为粗心大意感到抱歉 :P

@S1ngS1ng S1ngS1ng added the need update Use when a translation (?) PR has been reviewed and needs to address comments label Aug 1, 2018
- update for comment
考虑json文件中没有翻译title,所以这里也保留
Copy link

@wudifeixue wudifeixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

具体内容看评论吧

@@ -1,8 +1,8 @@
# Introduction to the JavaScript Algorithms and Data Structures Projects #

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该是数据结构,Data Structures不只是数据。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有JavaScript并不是Javascript,要注意大小写哦。


Time to put your new JavaScript skills to work! These challenges will be similar to the algorithm scripting challenges but more difficult. This will allow you to prove how much you have learned.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个new没有翻译,而且JavaScript拼错了。注意大小写的拼写哦。


In this section you will create the following small JavaScript programs:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也要改一下JavaScript

@S1ngS1ng
Copy link
Contributor

S1ngS1ng commented Aug 1, 2018

@wudifeixue Diff Settings 里调成 split,然后在右边 comment。左边是原文

@wudifeixue
Copy link

@S1ngS1ng 奇怪了。这次可能是点错了。我的锅,不过上面的确实需要改一下 😄

- 修改 JavaScript 拼写
- 根据 comment 加上缺失的翻译
Copy link
Contributor

@S1ngS1ng S1ngS1ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need update Use when a translation (?) PR has been reviewed and needs to address comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants