macOS: Add symlink to /Applications and use bigger icons #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chennes can you merge this as well? |
|
huh, I didn't realize the bundle process isn't running for PRs, this breaks bundling for arm mac. Is there no way to set this manually without needing a pip package? |
|
Other options would be to use a nodejs tool, a shell script or creating our own solution. I assumed that developers in this project would be most familiar with Python so I chose this package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
dmgbuildto create a DMG with bigger icons and a symlink to/Applications. As it does not yet contain a background image or color, it adapts to dark and light mode settings:Partially addresses #242.