Cleanup dependencies breaking underscore into three modules.
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….find`, `lodash.debounce` and `lodash.throttle`.
Closed
FredrikNoren
added a commit
that referenced
this pull request
Oct 5, 2013
Cleanup dependencies breaking `underscore` into three modules.
|
Hey @jdalton just wanted to give you a heads up that I might need to switch back to underscore because of nwjs/nw.js#1199. Not set in stone that I'll be using node-webkit and it might be possible to solve it with lodash but at least you know why if I need to switch |
|
No need to switch back to underscore. I'll do a pull request that just uses the single lodash package (no deps). You'll get same support plus better perf than Underscore to boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #221.
Cleanup dependencies breaking
underscoreinto three moduleslodash.find,lodash.debounceandlodash.throttle.I ran
npm testand all passed.