-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle plugin buffer response #950
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/pnp6srqnl |
I've followed @jaredLunde's "Option 1" instructions here: #945 (reply in thread) I've run |
@gr2m I updated the plugin to return |
I have reverted this change directly in Did you check if this pull request fixes the problem for you? |
The old plugin returned a binary string. It will still be corrupted w/ this PR because this doesn't attempt to handle binary strings, it just fixes a bug where you couldn't return just a buffer. You had to return an object Sequence of events was something like:
|
@FredKSchott could we create a testcase with a minimal plugin local to the test? |
@gr2m I'd rather not implement a new test suite as a part of this PR, but I definitely agree that we're overdue. I actually think that testing would be a great place for you to dig into to set up these things for the long term. Added a note that this has been manually tested |
Changes
return Buffer;
from pluginsTesting