Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help wanted: create tests for internal plugins #1019

Closed
11 of 12 tasks
gr2m opened this issue Sep 8, 2020 · 21 comments
Closed
11 of 12 tasks

Help wanted: create tests for internal plugins #1019

gr2m opened this issue Sep 8, 2020 · 21 comments
Labels
contributors welcome! contributors welcome!

Comments

@gr2m
Copy link
Contributor

gr2m commented Sep 8, 2020

Original Discussion: #958 (comment)
/cc @FredKSchott @drwpow @ralphtheninja

Snowpack's internal plugins do not currently have good test coverage. We would like to change that 😄

If anyone would like to contribute to Snowpack, comment which one of the plugins below you would like to claim, and create tests similar to what @Akimyou did in #984. The tests do not need to be complete, we can iterate. Few tests are better than none :)

Once all plugins are tested, close issue and update #958 (comment)

@MoonBall
Copy link
Contributor

MoonBall commented Sep 9, 2020

I would like to add test for plugin-webpack.

Edit: @ralphtheninja started this work in #1012 (comment). So I will contribute to plugin-dotenv.

@gr2m
Copy link
Contributor Author

gr2m commented Sep 9, 2020

@ralphtheninja just to confirm, are you working on test for plugin-webpack?

@ralphtheninja
Copy link
Contributor

@gr2m Nope, I never got started on it.

@gr2m
Copy link
Contributor Author

gr2m commented Sep 9, 2020

no worries, @MoonBall would you like to work on it? If not I'd do it myself, I think it's the most important one to have tests right now

@MoonBall
Copy link
Contributor

@gr2m I started plugin-dotenv. So you do it.

@JennieJi
Copy link
Contributor

Hi @gr2m I would like to try plugin-babel

@gr2m
Copy link
Contributor Author

gr2m commented Sep 14, 2020

Hi @JennieJi, I've signed you up. Thanks for looking into it 👍🏼

@MoonBall
Copy link
Contributor

@gr2m I would like to work on plugin-react-refresh.

@gr2m
Copy link
Contributor Author

gr2m commented Sep 20, 2020

You got it, thank you!

@FredKSchott
Copy link
Owner

Woo! This is exciting to see! @gr2m got one that I can take a look at? Maybe plugin-run-script & plugin-build-script?

@gr2m
Copy link
Contributor Author

gr2m commented Sep 21, 2020

Sure, just update the issue description for the one you are working on

@thescripted
Copy link
Contributor

I feel pretty comfortable working on tests for plugin-postcss

@gr2m
Copy link
Contributor Author

gr2m commented Oct 6, 2020

Great, all yours @thescripted!

@drwpow
Copy link
Collaborator

drwpow commented Oct 7, 2020

Just added a test for plugin-svelte in #1241!

@gr2m
Copy link
Contributor Author

gr2m commented Oct 8, 2020

@MoonBall just checking in, no rush: are you still working on / planning to work on plugin-react-refresh?

@gr2m
Copy link
Contributor Author

gr2m commented Oct 9, 2020

I'll work on the last unclaimed one: plugin-optimize.

Wonderful to see this all come together, thanks a bunch everyone 💐

@gr2m
Copy link
Contributor Author

gr2m commented Oct 9, 2020

actually plugin-build-script is up for grabs again ☝🏼

@FredKSchott
Copy link
Owner

Yup, anyone feel free to grab it! It should be pretty similar to the run-script tests

@gr2m
Copy link
Contributor Author

gr2m commented Oct 13, 2020

I'm looking into plugin-build-script myself now

@gr2m
Copy link
Contributor Author

gr2m commented Oct 14, 2020

I'll close the issue it's no longer actionable for people looking to contribut.

@thescripted @MoonBall let us know in case you won't be able to submit pull requests for the respective tests

@gr2m gr2m closed this as completed Oct 14, 2020
@FredKSchott
Copy link
Owner

woo! awesome job driving this @gr2m!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributors welcome! contributors welcome!
Projects
None yet
Development

No branches or pull requests

7 participants