-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help wanted: create tests for internal plugins #1019
Comments
I would like to add test for plugin-webpack. Edit: @ralphtheninja started this work in #1012 (comment). So I will contribute to |
@ralphtheninja just to confirm, are you working on test for |
@gr2m Nope, I never got started on it. |
no worries, @MoonBall would you like to work on it? If not I'd do it myself, I think it's the most important one to have tests right now |
@gr2m I started |
Hi @gr2m I would like to try |
Hi @JennieJi, I've signed you up. Thanks for looking into it 👍🏼 |
@gr2m I would like to work on |
You got it, thank you! |
Woo! This is exciting to see! @gr2m got one that I can take a look at? Maybe |
Sure, just update the issue description for the one you are working on |
I feel pretty comfortable working on tests for |
Great, all yours @thescripted! |
Just added a test for |
@MoonBall just checking in, no rush: are you still working on / planning to work on plugin-react-refresh? |
I'll work on the last unclaimed one: Wonderful to see this all come together, thanks a bunch everyone 💐 |
actually |
Yup, anyone feel free to grab it! It should be pretty similar to the run-script tests |
I'm looking into |
I'll close the issue it's no longer actionable for people looking to contribut. @thescripted @MoonBall let us know in case you won't be able to submit pull requests for the respective tests |
woo! awesome job driving this @gr2m! |
Original Discussion: #958 (comment)
/cc @FredKSchott @drwpow @ralphtheninja
Snowpack's internal plugins do not currently have good test coverage. We would like to change that 😄
If anyone would like to contribute to Snowpack, comment which one of the plugins below you would like to claim, and create tests similar to what @Akimyou did in #984. The tests do not need to be complete, we can iterate. Few tests are better than none :)
plugin-parcelNo longer supportedOnce all plugins are tested, close issue and update #958 (comment)
The text was updated successfully, but these errors were encountered: