Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all supported providers #315

Merged
merged 2 commits into from
Mar 22, 2017

Conversation

mikebeaton
Copy link
Contributor

How about this?
#311

@mikebeaton
Copy link
Contributor Author

mikebeaton commented Mar 15, 2017

The second commit is required, to fix a subtle problem otherwise on the first commit, see #311.

@FransBouma
Copy link
Owner

At first I thought: "Can you do that?" and whipped up a small program and indeed you can use that dynamic trick to do implicit reflection+property set, neat! It's not that slow either, couple of ms for 1m sets, so it's OK.

Will check the code and merge if everything is ok.

@FransBouma FransBouma merged commit 91aec16 into FransBouma:v2.0 Mar 22, 2017
@FransBouma
Copy link
Owner

Merged

@mikebeaton
Copy link
Contributor Author

mikebeaton commented Mar 22, 2017

Thanks for this.

Well worth doing the timing test - good point! (I actually found the technique from some other PR in Massive which changed some line(s) of code from not doing that to doing it... at least I think I did! ;) )

Can I ask, I would be very interested to find out more about how you are profiling Massive, more generally...

I've seen that you have references and calls to SD.Tools.OrmProfiler.Interceptor in the Massive tests - that must mean I have installed a Nuget package which is running and collecting data for me when I run the tests (!), but I have never tried to view the results. I did have a quick look and saw that ORMProfiler is a paid license tool (which I guess I wouldn't be looking to pay for in order to be able to (try to!) contribute fast, performant code for free, to an OSS project...).

And I also just recently saw the references in Dapper's Readme.md to your own RawDataAccessBencher and to InfoTechBridge's OrmBenchmark.

I suppose what I'm particularly asking is, as there any performance metrics you are especially looking at when you test a new PR? Presumably, if so, I'm guessing they'd be the ones from using ORMProfiler against the test results and/or keeping an eye on any changes in results from your own RawDataAccessBencher?

@mikebeaton mikebeaton deleted the TestAllSupportedProviders branch March 23, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants