Added module to scrap NBA Twitter handles #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def gen_player_twitters(self): | ||
| twitter_list = self.soup.find('div', {'id': 'div_stats'}) | ||
| headers = [th.text for th in twitter_list.find_all('th')] | ||
| rows = [row for row in twitter_list.tbody.find_all('tr')] |
There was a problem hiding this comment.
There is a problem with the indentation
There was a problem hiding this comment.
I'm confused: the indentation is obviously wrong in the commit but when I visit the file on my repo, it looks fine. file in repo
|
Thanks for your contribution. It is indeed useful and according to Nate Silver, professional gambler Haralabos Voulgaris, inputs data from players's Twitter to his ML models. |
it was fine on my macbook I swear.
|
Hi! I should have updated the indentation correctly. Thanks for pointing it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My contribution to this very cool package: I had needs to get the Twitter accounts off of basketball-reference.com and this package had a great foundation. The Twitter module simply scraps the page. I did not add any functionality to query it. I also included an example of what can be done.