-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace PySimpleGUI with Tkinter for Python GUI #130
Merged
JohnAZoidberg
merged 27 commits into
FrameworkComputer:main
from
moon-jam:tkinter-python-gui
Nov 25, 2024
Merged
Replace PySimpleGUI with Tkinter for Python GUI #130
JohnAZoidberg
merged 27 commits into
FrameworkComputer:main
from
moon-jam:tkinter-python-gui
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAZoidberg
force-pushed
the
tkinter-python-gui
branch
from
November 22, 2024 14:43
3eb7575
to
9d762f4
Compare
Signed-off-by: Daniel Schaefer <[email protected]>
I don't like the styling. And if we do want to change the styling we should use the built-in styling/theming facility instead of building it from scratch. https://tkdocs.com/tutorial/styles.html Signed-off-by: Daniel Schaefer <[email protected]>
Users don't usually need it, move it away. Signed-off-by: Daniel Schaefer <[email protected]>
Creates a window and draws on it Signed-off-by: Daniel Schaefer <[email protected]>
Draws on all that are connected. Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
- Include downloaded releases - Fix exe name Signed-off-by: Daniel Schaefer <[email protected]>
We removed the function earlier, and then introduced it back, but with different arguments. Signed-off-by: Daniel Schaefer <[email protected]>
JohnAZoidberg
force-pushed
the
tkinter-python-gui
branch
from
November 25, 2024 04:20
d308577
to
a6c0258
Compare
Otherwise the cli snake is broken Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
JohnAZoidberg
force-pushed
the
tkinter-python-gui
branch
from
November 25, 2024 05:54
7beb466
to
cce7898
Compare
JohnAZoidberg
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I think we're ready to migrate :D
- Make pygame an optional dependency - Avoid the pygame hello print on startup ``` pygame 2.6.1 (SDL 2.28.4, Python 3.13.0) Hello from the pygame community. https://www.pygame.org/contribute.html ``` Signed-off-by: Daniel Schaefer <[email protected]>
They're not really useful to the average user. Signed-off-by: Daniel Schaefer <[email protected]>
pyinstaller just runs the script, so we need to make the default, the gui. Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PySimpleGUI now requires a paid license for commercial use, and annual renewal for hobbyists starting from version 5. To avoid these costs and ensure long-term project stability, this PR replaces PySimpleGUI with Tkinter, which is free and included in Python’s standard library.
Fixes #105
Changes
Screenshots