feat(onboarding): accept children as props / retool the guide component #1
Conversation
| @@ -0,0 +1,25 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
can we not get away with using CSS triangles? if we have to use SVGs, should that that svg in a separate file and fix webpack if need be
There was a problem hiding this comment.
or rather, maybe change the tooltip to take a render prop so that we can let the consumer do whatever they want to the tooltip container?
There was a problem hiding this comment.
I think this component on itself can remain the same, and I may change the <Guide /> component in the future to accept a pointer render prop
| } | ||
| } | ||
|
|
||
| const hX = hx.isOutsideX(targetLeft + helperWidth, windowWidth) |
There was a problem hiding this comment.
i know you didn't write this, but these fiddly logic makes me a bit nervous without tests backing it
There was a problem hiding this comment.
yeah...I think in the future I'll revisit this and see about making this more local to web-client-components.
setsun
force-pushed
the
sl-onboarding
branch
2 times, most recently
from
9fbfc47 to
41bf612
Compare
GROW 290
This PR repurposes Reactour for the onboarding flow for the player page.
Essentially what I have done is change the library to accept React
childrenas props so it is easier to style the inner content.Also I've added a tooltip nub / beacons which are styles specific to our onboarding. Eventually as we move towards onboarding on the dashboard page, I would want to consider moving the positioning logic inside of @frameio/components and make it easier to test it.