-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Songs are scrobbled too often a lot #67
Comments
I have not been able to reproduce your issue (using Jellyfin 10.8.9) but I have added additional logging for jellyfin in the To track this down:
Then post the logs if it occurs, thanks. |
I have set the multi-scrobbler up like you described, during that I noticed that when I had two jellyfin clients open, both having tracks selected, one paused, one playing, the multi-scrobbler ends up doing this weird back-and-forth thing while not scrobbling at all:
Not sure if that's related but I thought it'd be interesting to point out. This exact situation is one I encounter a lot, since I often leave my home PC on when going to work and vice-versa. That said, I have not yet been able to reproduce the original issue. I will keep trying and keep you updated. |
Thanks for the logs. This is a good hint towards what might be happening. |
I can't seem to reproduce the issue anymore. Is it conceivable that it's related to memory usage? I saw that before I restarted multiscrobbler to set it up the way you described, it was using 10+ GB of RAM. That would explain why it's not happening anymore and might not until it's been running for a few weeks again like it was before. |
Wow!! That is definitely not normal ram usage for MS. Despite that your logs do hint that MS is not handling multiple "clients" for the same source well. For Jellyfin MS uses the MemorySource implementation where it has to independently keep track of when a track is considered playing and when it allow it to be scrobbled, because Jellyfin doesn't report that kind of information itself. It works decently in a "single user on a single client" scenario but is not handling your scenario well due to assumptions I made when coding it. Im working on refactoring it to handle that better. So the TLDR is that it may have been a memory leak causing weird issues or it could be these underlying problems I am refactoring for now, |
@BratPfanneTV I've implemented a fix so MS now tracks plays across users/platforms/devices separately. This should fix your issue. You can test this out on the |
@FoxxMD Hi! Just as I was about to download and run the new version, I noticed that the issue has finally re-appeared, so I'm concluding that it really must've had to do with the amount of time that the program ran for. This song "Overdose" by "Simbai" has been scrobbled multiple times and the logs for it look like this:
It's worth noting that as far as I know, I was not connected on multiple clients at the time of this happening, though I could be wrong. I just wanted to mention it so that, in case this new version doesn't fix it, the logs are available to look at. It's also worth noting that the node process for MS is once again on 10+ GB of RAM usage, according to |
@BratPfanneTV how has it been behaving for you this week? I'd encourage you to update again as I've made lots of fixes and improvements this week :) |
@juergenbr that's definitely not right! Unfortunately Deezer is not playing nice with me...my free account is not returning any play history (I can only listen to 30 seconds of a track?) so I'm not sure if this will work or not -- I've added a potential fix to the |
@FoxxMD I updated my container to the latest |
@BratPfanneTV any updates? |
In release 0.4.6. I'm closing this until/if Brat returns with an update. |
I have a jellyfin -> last.fm setup and it works great except that sometimes it scrobbles songs too often.
I have an 800 song playlist that I shuffle, so the same song coming on twice back to back is very unlikely,
yet I often see this:
in my last.fm library, and rarely I even encounter strange situations like this:
(this song was, also, only played once)
The logs in the web interface seem to be reflecting this:
The text was updated successfully, but these errors were encountered: