Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-scrobbler only submits the last 20 cached scrobbles to Maloja using Last.fm as a source #153

Closed
maluvola opened this issue May 6, 2024 · 7 comments

Comments

@maluvola
Copy link

maluvola commented May 6, 2024

  • multi-scrobbler: [0.6.5, no docker or flatpak]
  • maloja [3.2.2]
@FoxxMD
Copy link
Owner

FoxxMD commented May 6, 2024

Hello

This is by design. multi-scrobbler is not an application for importing your historical scrobbles from LastFM. If you'd like to import all of your scrobbles from LastFM please follow the directions in the Maloja documentation under How To Use -> Data.

multi-scrobbler is designed to be run continuously so it can monitor scrobbles in real time. The 20 scrobble value is in place to help "fill in the gaps" in the event it crashes or is stopped for some reason -- the cache is used to get any missed scrobbles during that down time. If this use case, getting that last 20 scrobbles, is not adequate for you please describe where it is failing and I may be able to address it.

Additionally, since you are running MS natively, you can adjust this value yourself to get more "cached" scrobbles, if you would like:

@maluvola
Copy link
Author

maluvola commented May 7, 2024

Thank you. The reason I want to increase the number of cached scrobbles is that I don't keep the server on at all times, and I like to have it mirrored with Last.fm. This way, scrobbles can be submitted to Maloja after I listen to music on my phone.

@FoxxMD
Copy link
Owner

FoxxMD commented May 7, 2024

Then increasing the limits I mentioned should accomplish your goal. Be aware that Last.FM will return a maximum of 200 scrobbles so that's as high as the limit in LastfmSource.ts can go. You should make sure to start multi-scrobbler before you have scrobbled that many tracks since last using it.

FoxxMD added a commit that referenced this issue May 16, 2024
…153

* Increase default backlog limits to maximum pagination supported by each source
* Add scrobbleBacklogCount config property so user can explicitly set # of tracks to backlog
FoxxMD added a commit that referenced this issue May 16, 2024
* Refresh recent scrobbles with a higher limit after initialization (maximum supported by api call)
* Implement controlling count in client config
@FoxxMD
Copy link
Owner

FoxxMD commented May 16, 2024

@maluvola please try pulling the develop branch. It has these changes in it:

  • sources pull the maximum # of listens supported by the api on startup (200 for last.fm)
  • clients pull the maximum # of scrobbles supported by the api for comparison on startup (100 for maloja)
  • source and client configs can specify these numbers for startup if the default maximum is not desirable:

ex lastfm.json

[
  {
    "name": "mylfm",
    "enable": true,
    "configureAs": "source",
    "data": {
    },
    "options": {
      "scrobbleBacklogCount": 100
    }
  }
]

ex maloja.json

[
  {
    "name": "default",
    "enable": true,
    "data": {
    },
    "options": {
      "refreshInitialCount": 20,
    }
  }
]

I believe this should address your issue?

@maluvola
Copy link
Author

Yes, it should. Does your previous answer work as well? I made the changes but haven't listened to more than a dozen tracks yet.

@FoxxMD
Copy link
Owner

FoxxMD commented May 20, 2024

Yes my previous answer will still work. The new solution in develop is a configuration-based version of my previous answer. I'd suggest switching to that, eventually, so that you can continue to pull updates to MS without having to resolve file changes. I will drop a comment here when the solution is included in a full release (probably next week).

@FoxxMD
Copy link
Owner

FoxxMD commented Jul 9, 2024

Released in v0.8.0

@FoxxMD FoxxMD closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants