[WIP] Introduce prepare-integration make target #298
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to prepare the VM filesystem for the tests.
This target is suppused to be run like so:
make prepare-integration integration
but currently the filesystem it creates is not bootable for some reason.
@Foxboron looking at the code it seems that there is some way to run the integration test but it's relying on things outside git. I tried to fill in the missing parts by wrapping the make_image.sh script in a docker command that would make it possible to run it locally.
I remember you mentioned u-root being used in
go-uefi
so I wonder if I should ditch this and try to useu-root
to build an initramfs that has sbctl in it. What do you think? I'm also fine dropping this completely until you find time to work on it yourself. I only mean to help, no pressure :).