Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 91-sbctl.install #266

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Update 91-sbctl.install #266

merged 1 commit into from
Dec 12, 2023

Conversation

cvlc12
Copy link
Contributor

@cvlc12 cvlc12 commented Dec 8, 2023 •
edited
Loading

Make it clear that messages are from sbctl, instead of them being lost in the kernel-install output.
Always say we're signing the kernel

@cvlc12 cvlc12 temporarily deployed to Build, sign, release binaries December 8, 2023 11:42 — with GitHub Actions Inactive
@cvlc12 cvlc12 temporarily deployed to Build, sign, release binaries December 8, 2023 11:42 — with GitHub Actions Inactive
@cvlc12 cvlc12 temporarily deployed to Build, sign, release binaries December 8, 2023 11:42 — with GitHub Actions Inactive
@Foxboron
Copy link
Owner

Foxboron commented Dec 8, 2023

Generally looks good, but please squash the changes.

@cvlc12
Copy link
Contributor Author

cvlc12 commented Dec 8, 2023

done, also added a shellcheck disable comment

@Foxboron Foxboron merged commit b18c73f into Foxboron:master Dec 12, 2023
@Foxboron
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cvlc12 @Foxboron