Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-keys allows for specifying an export directory #259

Merged

Conversation

cosmastech
Copy link
Contributor

To resolve #258

This allows the end-user to specify an export path. Not entirely sure what the GUID is useful for, tbh, but since I didn't have a /usr/share/secureboot/ directory, I was still having trouble running this command. I added the ability to specify the database-path too.

@cosmastech cosmastech temporarily deployed to Build, sign, release binaries November 11, 2023 11:19 — with GitHub Actions Inactive
@cosmastech cosmastech temporarily deployed to Build, sign, release binaries November 11, 2023 11:19 — with GitHub Actions Inactive
@cosmastech cosmastech temporarily deployed to Build, sign, release binaries November 11, 2023 11:20 — with GitHub Actions Inactive
@Foxboron
Copy link
Owner

Missing some documentation in the manpage, else it looks great :) Thanks!

https://github.com/Foxboron/sbctl/blob/master/docs/sbctl.8.txt#L28

@Foxboron
Copy link
Owner

Squash the two last commits together and it's fine :) Thanks!

@cosmastech cosmastech force-pushed the feature/issue-258_specify-export-path branch from 31436d4 to c5f7129 Compare November 11, 2023 11:51
@Foxboron Foxboron merged commit a68bde8 into Foxboron:master Nov 16, 2023
@Foxboron
Copy link
Owner

Thanks!

@cosmastech
Copy link
Contributor Author

Thanks!

Thanks for your patience with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: create-keys with --export
2 participants