Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make delimiter optional while staying backwards compatible #42

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

FourierTransformer
Copy link
Owner

@FourierTransformer FourierTransformer commented Aug 5, 2024

Fixes

  • Checks the type of the second argument and then handles it either as a delimiter or the options table. Allows the code to remain backwards compatible. (Optional Delimiter #23)
  • Fixes a bug if you reuse the options table where the bufferSize can only be specified using 'parseLine' would pop up. (Can't call ftcsv.parse with a string twice in a row #39)
  • Updated README with some clarificatoins

closes #23 and #39

@FourierTransformer FourierTransformer merged commit 11f1c6e into master Aug 6, 2024
6 checks passed
@FourierTransformer FourierTransformer deleted the optional-delimiter branch August 6, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional Delimiter
1 participant