Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically link libstdc++ and libgcc #25

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

apkar
Copy link
Contributor

@apkar apkar commented Dec 19, 2018

Statically linking libstdc++ known to cause issues with the plugin architecture. With the cleanup of plugin interface, #24, this change shouldn't cause any issues. But, I suspect we might have to revisit this in future when we end up having external plugins. For now, this change is important to make CentOS builds easier, #6.

Copy link
Contributor

@dongxinEric dongxinEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apkar apkar merged commit 2824f92 into FoundationDB:master Dec 19, 2018
@apkar apkar deleted the static-linking branch February 21, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants