Fix for compound index selection. #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajbeamon
approved these changes
May 2, 2019
|
This looks good to me, assuming index names are unique. |
Yeah, that is taken care by the create index code. It makes sure that there are no two indexes with the same name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc Layer maintains indexes with two level map. The first level to identify simple indexes and second level for compound indexes. Set that maintains the compound indexes with the same prefix are has the wrong comparator that matches the indexes of the same size. This patch fixes the comparator.
Thankfully this structure is not used in the write path, otherwise, we will have to rebuild the indexes.