Fix the bug where dropIndex command is not replying all necessary fie… #175
Conversation
…lds in error cases. Audited all places where ok is 0 to make sure $err and errmsg are both returned
| @@ -608,7 +608,11 @@ ACTOR static Future<Reference<ExtMsgReply>> doDropIndexesActor(Reference<ExtConn | |||
| reply->addDocument(BSON("nIndexesWas" << dropped + 1 << "ok" << 1.0)); | |||
| return reply; | |||
| } else { | |||
| reply->addDocument(BSON("ok" << 0.0)); | |||
| // clang-format off | |||
| reply->addDocument(BSON("ok" << 0.0 << | |||
There was a problem hiding this comment.
I know you didn't change this. Can you make sure if ok value needs to be float or int?
There was a problem hiding this comment.
Both are fine. I believe in most main stream languages, user can compare double, float, int and long with each other without having to explicitly cast the types.
There was a problem hiding this comment.
And our code base does have mixed usage of double and int, and sometime long. We'd better clean that up too someday.
There was a problem hiding this comment.
Can you please raise an issue for that? Also, OP_REPLY response flag need to be set apparently for $err to work. We do set for OP_GETMORE but nowhere else. You might want to mention that in the issue.
https://docs.mongodb.com/v3.0/reference/mongodb-wire-protocol/#wire-op-reply
…lds in error cases. Audited all places where ok is 0 to make sure $err and errmsg are both returned